Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 8, 2025

Writes to null device files were incorrectly requiring approval when chat.tools.terminal.blockDetectedFileWrites is set to outsideWorkspace. These are OS-provided device files that safely discard data and should not trigger workspace boundary checks.

Changes:

  • Added _isSafeNullDevicePath() to identify null devices across platforms:
    • /dev/null (Unix/Linux)
    • NUL (Windows CMD, case-insensitive)
    • $null (PowerShell)
  • Modified _getResult() to skip workspace validation for null device paths, checked before variable detection to handle $null's $ character
  • Updated tests to verify null device writes are auto-approved even without workspace folders

Fixes the scenario shown in the issue where 2>/dev/null triggers an unnecessary approval prompt.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • redirector.gvt1.com
    • Triggering command: /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --crashpad-handler-pid=16574 --enable-crash-reporter=1c02c580-0355-4167-9847-bfd381c0e1a4,no_channel --user-data-dir=/tmp/vscode-tests-1762606799440 --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,16173230850607296853,14407152185923085611,262144 --enable-features=PdfUseShowSaveFilePicker --disable-features=ScreenAIOCREnabled,SpareRendererForSitePerProcess --variations-seed-version (dns block)
    • Triggering command: .build/electron/code-oss test/unit/electron/index.js --crash-reporter-directory=/home/REDACTED/work/vscode/vscode/.build/crashes --grep CommandLineFileWriteAnalyzer (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Auto-approve writes to /dev/null</issue_title>
<issue_description>Just saw this come up from Sonnet 4.5, seems like a path we can safely allowlist:

Image</issue_description>

<agent_instructions>Allow writing to /dev/null, $null (pwsh) and any other relevant safe files. This is in commandLineFileWriteAnalyzer.ts</agent_instructions>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com>
@Tyriar Tyriar added this to the November 2025 milestone Nov 8, 2025
Copilot AI changed the title [WIP] Allow auto-approve writes to /dev/null Auto-approve writes to null device files (/dev/null, $null, NUL) Nov 8, 2025
Copilot finished work on behalf of Tyriar November 8, 2025 13:07
Copilot AI requested a review from Tyriar November 8, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-approve writes to /dev/null

2 participants