chat - track and apply defaultVisibilityMarker

[bpasero]

https://github.com/microsoft/vscode-internalbacklog/issues/6168

[Copilot]

Pull Request Overview

This PR adds a new experimental configuration setting workbench.secondarySideBar.defaultVisibilityMarker to help migrate "pre-AI" workspaces. The marker is used to determine whether the default secondary sidebar setting has been applied to a workspace, allowing the code to reset the auxiliary bar visibility state for workspaces that haven't migrated yet.

• Adds a new experimental configuration setting for tracking migration state
• Implements migration logic to reset auxiliary bar state for unmigrated workspaces

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
src/vs/workbench/browser/workbench.contribution.ts	Adds the new workbench.secondarySideBar.defaultVisibilityMarker experimental configuration setting
src/vs/workbench/browser/layout.ts	Implements migration logic in loadKeyFromStorage to reset auxiliary bar visibility for unmigrated workspaces

[Copilot]

The type property should be consistently quoted with single quotes to match the surrounding code style. All other properties in this file use single quotes around property names.

Suggested change

	type: 'string',
	'type': 'string',

[Copilot]

The configuration value workbench.secondarySideBar.defaultVisibilityMarker is retrieved twice using configurationService.getValue(). Consider storing it in a local variable to avoid redundant lookups.

Suggested change

	key.name === LayoutStateKeys.AUXILIARYBAR_HIDDEN.name &&
	typeof this.configurationService.getValue('workbench.secondarySideBar.defaultVisibilityMarker') === 'string' &&
	this.storageService.get(this.configurationService.getValue('workbench.secondarySideBar.defaultVisibilityMarker'), StorageScope.WORKSPACE) === undefined
	) {
	value = undefined;
	key.name === LayoutStateKeys.AUXILIARYBAR_HIDDEN.name
	) {
	const defaultVisibilityMarker = this.configurationService.getValue('workbench.secondarySideBar.defaultVisibilityMarker');
	if (
	typeof defaultVisibilityMarker === 'string' &&
	this.storageService.get(defaultVisibilityMarker, StorageScope.WORKSPACE) === undefined
	) {
	value = undefined;
	}

[Copilot]

The magic string 'workbench.secondarySideBar.defaultVisibilityMarker' should be extracted as a constant. Consider adding it to the WorkbenchLayoutSettings enum (lines 2755-2762) for consistency with other configuration keys used in this class.