Skip to content

get placeholder to be read by screen reader for chat inputs #276195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meganrogge merged 2 commits into from
Nov 11, 2025
Merged

get placeholder to be read by screen reader for chat inputs #276195

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64788c5
fix #269070
meganrogge Nov 7, 2025
91f5cf0
avoid getting element directly
meganrogge Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/vs/workbench/contrib/chat/browser/contrib/chatInputEditorContrib.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import { IPromptsService } from '../../common/promptSyntax/service/promptsServic
import { IChatWidget } from '../chat.js';
import { ChatWidget } from '../chatWidget.js';
import { dynamicVariableDecorationType } from './chatDynamicVariables.js';
import { NativeEditContextRegistry } from '../../../../../editor/browser/controller/editContext/native/nativeEditContextRegistry.js';

const decorationDescription = 'chat';
const placeholderDecorationType = 'chat-session-detail';
Expand Down Expand Up @@ -134,12 +135,14 @@ class InputEditorDecorations extends Disposable {

const viewModel = this.widget.viewModel;
if (!viewModel) {
this.updateAriaPlaceholder(undefined);
return;
}

if (!inputValue) {
const mode = this.widget.input.currentModeObs.get();
const placeholder = mode.argumentHint?.get() ?? mode.description.get() ?? '';
const displayPlaceholder = viewModel.inputPlaceholder || placeholder;

const decoration: IDecorationOptions[] = [
{
Expand All @@ -151,16 +154,19 @@ class InputEditorDecorations extends Disposable {
},
renderOptions: {
after: {
contentText: viewModel.inputPlaceholder || placeholder,
contentText: displayPlaceholder,
color: this.getPlaceholderColor()
}
}
}
];
this.updateAriaPlaceholder(displayPlaceholder || undefined);
this.widget.inputEditor.setDecorationsByType(decorationDescription, placeholderDecorationType, decoration);
return;
}

this.updateAriaPlaceholder(undefined);

const parsedRequest = this.widget.parsedInput.parts;

let placeholderDecoration: IDecorationOptions[] | undefined;
Expand Down Expand Up @@ -295,6 +301,19 @@ class InputEditorDecorations extends Disposable {

this.widget.inputEditor.setDecorationsByType(decorationDescription, variableTextDecorationType, varDecorations);
}

private updateAriaPlaceholder(value: string | undefined): void {
const nativeEditContext = NativeEditContextRegistry.get(this.widget.inputEditor.getId());
const domNode = nativeEditContext?.domNode.domNode;
if (!domNode) {
return;
}
if (value && value.trim().length) {
domNode.setAttribute('aria-placeholder', value);
} else {
domNode.removeAttribute('aria-placeholder');
}
}
}

class InputEditorSlashCommandMode extends Disposable {
Expand Down
Loading