Fix IME composition causing premature filtering in tree find widget #275866
+9
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #274958
During IME composition (e.g., typing
¨+u→ü), the find widget filtered on intermediate characters, hiding content before composition completed.Changes
FindInput (
src/vs/base/browser/ui/findinput/findInput.ts)onInputevent with existingimeSessionInProgressflagcompositionendwith final composed textFindWidget (
src/vs/base/browser/ui/tree/abstractTree.ts)findInput.onInputinstead offindInput.onDidChangeonInputrespects IME composition boundaries;onDidChangecontinues firing on every keystrokeBehavior
Before: Input events during composition → premature filtering → content disappears
After: Composition blocks input events → single event on compositionend → correct filtering
Maintains backward compatibility. Consumers needing immediate updates can continue using
onDidChange.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.