-
Notifications
You must be signed in to change notification settings - Fork 542
DacPac Dialog Bug Fixes and Feature Flag Implementation #20505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
1b8d66b
9b9e982
9d48496
e79fedc
f2b99dd
68f0924
9ca59e4
d726761
ad3ce87
03f5260
3914a99
ab77938
fa3e245
b74be0c
c1ce2c4
21ac90a
ea0ee8e
35e4398
fcd13a7
8ec36a3
f219588
b2fad95
7ee8fd7
a9c794c
6056efd
df8fc7a
f0b6a2a
5e59d0c
96ba664
390ef10
655f146
60744d1
6c86f32
c82bcb2
92d6071
b81ec23
25c78de
a8671e6
bf2bbd1
d743607
4c7ee57
53cd503
83bddff
f071da3
f8612ab
02beea3
76fa8a0
80ee27b
3102d0d
e0f5b32
3f7bed7
b0826be
317c470
2cc5d33
15fa192
badecf1
ba9709f
151404a
1a049b5
b5cb330
fd7d8cb
5fe5745
cfea503
558740e
b1d815b
166e6ea
5b2f6ff
988fb18
9201634
9f91670
b620e16
b1a96cd
c3704c0
51de7c0
260ab45
b5baa8f
96c4536
4e2be14
255fae6
6bf885c
b091124
7ffd313
e51bc24
d584e7b
1cbf119
39ba016
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -225,6 +225,12 @@ | |||||||
| <trans-unit id="++CODE++a187c7382f4026c938df224dd7484977538cd582c67e94b62861499fe68c68a4"> | ||||||||
| <source xml:lang="en">Application Version</source> | ||||||||
| </trans-unit> | ||||||||
| <trans-unit id="++CODE++3bce900ec4939301dbcf9f9199be4416b9c310a90af78e6a083fcbb7c517696e"> | ||||||||
| <source xml:lang="en">Application version must be in format n.n.n or n.n.n.n where n is a number (e.g., 1.0.0.0)</source> | ||||||||
| </trans-unit> | ||||||||
| <trans-unit id="++CODE++70e9cc5a50f7eb5ba95c18dffd367c22caeef8814be8188d6af4f5654a8fc728"> | ||||||||
| <source xml:lang="en">Application version must be in format n.n.n.n where n is a number (e.g., 1.0.0.0)</source> | ||||||||
| </trans-unit> | ||||||||
|
Comment on lines
+231
to
+233
|
||||||||
| <trans-unit id="++CODE++70e9cc5a50f7eb5ba95c18dffd367c22caeef8814be8188d6af4f5654a8fc728"> | |
| <source xml:lang="en">Application version must be in format n.n.n.n where n is a number (e.g., 1.0.0.0)</source> | |
| </trans-unit> |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -2149,6 +2149,38 @@ export class DacpacDialog { | |||||
| public static Select = l10n.t("Select"); | ||||||
| public static Save = l10n.t("Save"); | ||||||
| public static Files = l10n.t("Files"); | ||||||
| public static InvalidApplicationVersion = l10n.t( | ||||||
| "Application version must be in format n.n.n.n where n is a number (e.g., 1.0.0.0)", | ||||||
|
||||||
| "Application version must be in format n.n.n.n where n is a number (e.g., 1.0.0.0)", | |
| "Application version must be in format n.n.n or n.n.n.n where n is a number (e.g., 1.0.0.0)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two different validation messages for application version format in this localization bundle. Line 855 correctly describes the validation logic allowing "n.n.n or n.n.n.n", while line 1990 only mentions "n.n.n.n". This creates inconsistency in error messages. Only one message should be used, and it should match the validation logic that accepts both 3 and 4 part versions.