Linkify line numbers to enable precise line navigation from chat responses #1775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
reviewed
Nov 3, 2025
Contributor
mjbvz
left a comment
mjbvz
left a comment
There was a problem hiding this comment.
I think we should re-evaluate if we can get models to generate proper links that we can easily parse. Earlier models were not great at this and we still likely need to be a little pragmatic, but I'm really not a fan of extending the link handler to try parsing sentences like this
|
|
||
| async linkify(text: string, context: LinkifierContext, token: CancellationToken): Promise<LinkifiedText> { | ||
| const parts: Array<Promise<LinkifiedPart> | LinkifiedPart> = []; | ||
| const parts: LinkifiedPart[] = []; |
Contributor
There was a problem hiding this comment.
We have an array of promises because we want to resolve all the links in parallel instead of sequentially. I'd prefer keeping it like that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When chat response mentions a file with a line hint, for example:
utils/logger.ts (line 42)
in lines 10–12 of server.py
config.json, lines 5 through 9
at line 7 in README.md
this change now upgrades that file reference so clicking it opens the file directly at the specified line (first line of a range for now). This works whether the line annotation appears after the filename or before it.