Update comment to better describe the serviceBroker param #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AArnott
requested changes
Oct 17, 2025
| /// Initializes a new instance of the <see cref="LazyAuthorizationServiceProxy"/> class. | ||
| /// </summary> | ||
| /// <param name="serviceBroker">A service broker used to acquire the activation service.</param> | ||
| /// <param name="serviceBroker">An optional service broker used to acquire the activation service.</param> |
Member
There was a problem hiding this comment.
This still doesn't document what behavior will be when the service broker is missing.
In fact the class already didn't document what would happen when the underlying auth service was missing. Maybe document them together at the class level under <remarks>.
Member
Author
There was a problem hiding this comment.
I'll write up something more thorough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.