-
Notifications
You must be signed in to change notification settings - Fork 18
docs: Revamp Deployment Docs for Unified Data Foundation in Fabric Solution Accelerator #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR significantly improves the deployment documentation for the Unified Data Foundation with Fabric solution accelerator, focusing on enhanced clarity, structure, and usability for new users and teams deploying across different environments.
Key changes:
- Added Quick Navigation section with direct links to key sections for easier document navigation
- Reorganized prerequisites, deployment overview, and deployment options sections for better flow and clarity
- Enhanced troubleshooting guidance for Databricks setup with detailed manual external location creation steps
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| docs/SetupDatabricks.md | Added comprehensive troubleshooting section for manually creating external locations when not auto-created |
| docs/DeploymentGuideFabricManual.md | Simplified variable descriptions and streamlined deployment instructions by removing redundant quick start section |
| docs/DeploymentGuideFabric.md | Major restructuring with new Quick Navigation, reorganized prerequisites with detailed software/permissions tables, improved deployment overview explaining two-phase approach, and standardized section headers with emojis |
| docs/DeploymentGuideDatabricks.md | Added folder creation step before mirroring Azure Databricks catalog, improving workspace organization |
Comments suppressed due to low confidence (1)
docs/DeploymentGuideFabric.md:370
- Duplicate "Deployment Options" section detected. This section appears twice in the document:
- First occurrence at line 158 (new location in this PR)
- Second occurrence at line 307 (appears to be the old location that should be removed)
The content of both sections is identical. The duplicate at line 307 should be removed to avoid confusion and maintain document consistency.
## Deployment Options
Choose your deployment environment based on your workflow and requirements. All options use the same [Quick Start commands](#quick-start) with environment-specific setup.
| Environment | Best For | Setup Required | Notes |
|-------------|----------|----------------|-------|
| **[Local Machine](#local-machine)** | Full development control | Install [software requirements](#-software-requirements) | Most flexible, requires local setup |
| **[Azure Cloud Shell](#azure-cloud-shell)** | Zero setup | Just a web browser | Pre-configured tools, session timeouts |
| **[GitHub Codespaces](#github-codespaces)** | Team consistency | GitHub account | Cloud development environment |
| **[Dev Container](#vs-code-dev-container)** | Standardized tooling | Docker Desktop + VS Code | Containerized consistency |
| **[GitHub Actions](#github-actions-cicd)** | Automated CI/CD | Service principal setup | Production deployments |
### Local Machine
Deploy with full control over your development environment.
**Setup requirements**: Install the [software requirements](#-software-requirements)
**Deployment**: Use the standard [Quick Start commands](#quick-start)
### Azure Cloud Shell
Deploy from Azure's browser-based terminal with zero local installation.
**Setup**: Open [Azure Cloud Shell](https://shell.azure.com) and install Azure Developer CLI:
```bash
curl -fsSL https://aka.ms/install-azd.sh | bash && exec bash
Deployment: Run the Quick Start commands (Azure CLI pre-authenticated)
GitHub Codespaces
Deploy from a cloud development environment with pre-configured tools.
Setup:
- Go to the repository
- Click Code → Codespaces → Create codespace
Deployment: Install azd and run Quick Start commands with device authentication:
# Install azd if needed
curl -fsSL https://aka.ms/install-azd.sh | bash && exec bash
# Use device code authentication
az login --use-device-code
azd auth login --use-device-code
# Continue with Quick Start deployment commandsVS Code Dev Container
Deploy from a containerized environment for team consistency.
Setup:
- Install Docker Desktop and Dev Containers extension
- Clone repository and open in VS Code
- Reopen in container when prompted
Deployment: All tools pre-installed - run Quick Start commands directly
GitHub Actions (CI/CD)
Automated deployment using the included workflow.
Setup: Configure repository variables and set up service principal with federated credentials
Triggers: Push to main branch or manual workflow dispatch
</details>
---
💡 <a href="/microsoft/unified-data-foundation-with-fabric-solution-accelerator/new/main/.github/instructions?filename=*.instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how to get started</a>.
| | Tool | Version | Purpose | Download | | ||
| |------|---------|---------|----------| |
Copilot
AI
Dec 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The table header row uses inconsistent pipe alignment. The first column should start with a pipe character like the data rows for proper markdown table formatting.
Suggested fix:
| Tool | Version | Purpose | Download |
|------|---------|---------|----------|| | Section | Description | | ||
| |---------|-------------| |
Copilot
AI
Dec 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The table header row uses inconsistent pipe alignment. The first column should start with a pipe character like the data rows for proper markdown table formatting.
Suggested fix:
| Section | Description |
|---------|-------------|| | Environment | Best For | Setup Required | Notes | | ||
| |-------------|----------|----------------|-------| |
Copilot
AI
Dec 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The table header row uses inconsistent pipe alignment. The first column should start with a pipe character like the data rows for proper markdown table formatting.
Suggested fix:
| Environment | Best For | Setup Required | Notes |
|-------------|----------|----------------|-------|
docs/DeploymentGuideFabric.md
Outdated
| The deployment executes in two coordinated phases using dedicated scripts: | ||
| | Environment | Best For | Setup Required | Notes | | ||
| |-------------|----------|----------------|-------| | ||
| | **[Local Machine](#local-machine)** | Full development control | Install [software requirements](#-software-requirements) | Most flexible, requires local setup | |
Copilot
AI
Dec 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broken internal link reference. The link [software requirements](#-software-requirements) references a section that doesn't exist. The actual section is titled "Software Tools" (line 40), so the link should be [software requirements](#️⃣-software-tools) or the section should be renamed to "Software Requirements" to match the link text.
docs/DeploymentGuideFabric.md
Outdated
| - **Sample Data**: Uploads CSV files to bronze lakehouse ⚠️ *overwrites existing files with same names* | ||
| - **Power BI Reports**: Creates or overwrites dashboard components for data visualization ⚠️ *replaces existing reports with same names* | ||
| - **Administrators**: Adds new workspace administrators without removing existing ones | ||
| **Setup requirements**: Install the [software requirements](#-software-requirements) |
Copilot
AI
Dec 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broken internal link reference. The link [software requirements](#-software-requirements) references a section that doesn't exist. The actual section is titled "Software Tools" (line 40), so the link should be [software requirements](#️⃣-software-tools) or the section should be renamed to "Software Requirements" to match the link text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
docs/DeploymentGuideFabric.md
Outdated
| - **New to this solution?** Start with [Deployment Overview](#deployment-overview) → [Prerequisites](#prerequisites) → [Quick Start](#quick-start) | ||
| - **Ready to deploy?** Jump directly to [Quick Start](#quick-start) |
Copilot
AI
Dec 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The anchor links in these lines are inconsistent with the actual heading anchors. When headings include emojis, GitHub generates anchors with the emoji converted to a dash. The correct anchors should be:
#-deployment-overview(not#deployment-overview)#-prerequisites(not#prerequisites)#-quick-start(not#quick-start)
These should match the format used in the table on lines 19-27 for consistency.
| - **New to this solution?** Start with [Deployment Overview](#deployment-overview) → [Prerequisites](#prerequisites) → [Quick Start](#quick-start) | |
| - **Ready to deploy?** Jump directly to [Quick Start](#quick-start) | |
| - **New to this solution?** Start with [Deployment Overview](#-deployment-overview) → [Prerequisites](#-prerequisites) → [Quick Start](#-quick-start) | |
| - **Ready to deploy?** Jump directly to [Quick Start](#-quick-start) |
docs/DeploymentGuideFabric.md
Outdated
| - *Data*: Preserved (sample data is re-uploaded if missing). | ||
| - *Admins*: New admins are added; existing ones remain. | ||
|
|
||
| The deployment orchestration coordinates both phases, passing deployment parameters and ensuring proper sequencing. See [deployment options](#deployment-options) for different ways to run this deployment based on your preferred environment. |
Copilot
AI
Dec 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The anchor link #deployment-options is incorrect. The heading ## 💻 Deployment Options generates the anchor #-deployment-options (emoji becomes a dash). This should be updated to #-deployment-options to match the actual heading anchor.
| The deployment orchestration coordinates both phases, passing deployment parameters and ensuring proper sequencing. See [deployment options](#deployment-options) for different ways to run this deployment based on your preferred environment. | |
| The deployment orchestration coordinates both phases, passing deployment parameters and ensuring proper sequencing. See [deployment options](#-deployment-options) for different ways to run this deployment based on your preferred environment. |
docs/DeploymentGuideFabric.md
Outdated
| ## Deployment Overview | ||
| ## 💻 Deployment Options | ||
|
|
||
| Choose your deployment environment based on your workflow and requirements. All options use the same [Quick Start commands](#quick-start) with environment-specific setup. |
Copilot
AI
Dec 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The anchor link #quick-start is incorrect. The heading ## 🚀 Quick Start generates the anchor #-quick-start (emoji becomes a dash). This should be updated to #-quick-start to match the actual heading anchor.
docs/DeploymentGuideFabric.md
Outdated
| 1. **Infrastructure Provisioning** - Executes [`main.bicep`](../infra/main.bicep) to create Azure resources using [ARM idempotency](https://learn.microsoft.com/azure/azure-resource-manager/templates/deployment-tutorial-local-template?tabs=azure-powershell#deploy-template): | ||
| - **Microsoft Fabric Capacity**: Dedicated compute resources with configured admin permissions (updates configuration if parameters change) | ||
| - **Resource Group**: Container for all Azure resources | ||
| **Deployment**: Use the standard [Quick Start commands](#quick-start) |
Copilot
AI
Dec 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The anchor link #quick-start is incorrect. The heading ## 🚀 Quick Start generates the anchor #-quick-start (emoji becomes a dash). This should be updated to #-quick-start to match the actual heading anchor.
docs/DeploymentGuideFabric.md
Outdated
| curl -fsSL https://aka.ms/install-azd.sh | bash && exec bash | ||
| ``` | ||
|
|
||
| **Deployment**: Run the [Quick Start commands](#quick-start) (Azure CLI pre-authenticated) |
Copilot
AI
Dec 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The anchor link #quick-start is incorrect. The heading ## 🚀 Quick Start generates the anchor #-quick-start (emoji becomes a dash). This should be updated to #-quick-start to match the actual heading anchor.
| **Deployment**: Run the [Quick Start commands](#quick-start) (Azure CLI pre-authenticated) | |
| **Deployment**: Run the [Quick Start commands](#-quick-start) (Azure CLI pre-authenticated) |
docs/DeploymentGuideFabric.md
Outdated
| 2. Clone repository and open in VS Code | ||
| 3. Reopen in container when prompted | ||
|
|
||
| **Deployment**: All tools pre-installed - run [Quick Start commands](#quick-start) directly |
Copilot
AI
Dec 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The anchor link #quick-start is incorrect. The heading ## 🚀 Quick Start generates the anchor #-quick-start (emoji becomes a dash). This should be updated to #-quick-start to match the actual heading anchor.
| **Deployment**: All tools pre-installed - run [Quick Start commands](#quick-start) directly | |
| **Deployment**: All tools pre-installed - run [Quick Start commands](#-quick-start) directly |
docs/DeploymentGuideFabric.md
Outdated
| | **[Local Machine](#local-machine)** | Full development control | Install [software requirements](#software-requirements) | Most flexible, requires local setup | | ||
| | **[Azure Cloud Shell](#azure-cloud-shell)** | Zero setup | Just a web browser | Pre-configured tools, session timeouts | | ||
| | **[GitHub Codespaces](#github-codespaces)** | Team consistency | GitHub account | Cloud development environment | | ||
| | **[Dev Container](#vs-code-dev-container)** | Standardized tooling | Docker Desktop + VS Code | Containerized consistency | | ||
| | **[GitHub Actions](#github-actions-cicd)** | Automated CI/CD | Service principal setup | Production deployments | |
Copilot
AI
Dec 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The anchor links in this table row reference incorrect heading anchors. The headings include numbers (e.g., ### 1. Local Machine), so the anchors should be:
#1-local-machine(not#local-machine)#2-azure-cloud-shell(not#azure-cloud-shell)#3-github-codespaces(not#github-codespaces)#4-vs-code-dev-container(not#vs-code-dev-container)#5-github-actions-cicd(not#github-actions-cicd)
| | **[Local Machine](#local-machine)** | Full development control | Install [software requirements](#software-requirements) | Most flexible, requires local setup | | |
| | **[Azure Cloud Shell](#azure-cloud-shell)** | Zero setup | Just a web browser | Pre-configured tools, session timeouts | | |
| | **[GitHub Codespaces](#github-codespaces)** | Team consistency | GitHub account | Cloud development environment | | |
| | **[Dev Container](#vs-code-dev-container)** | Standardized tooling | Docker Desktop + VS Code | Containerized consistency | | |
| | **[GitHub Actions](#github-actions-cicd)** | Automated CI/CD | Service principal setup | Production deployments | | |
| | **[Local Machine](#1-local-machine)** | Full development control | Install [software requirements](#software-requirements) | Most flexible, requires local setup | | |
| | **[Azure Cloud Shell](#2-azure-cloud-shell)** | Zero setup | Just a web browser | Pre-configured tools, session timeouts | | |
| | **[GitHub Codespaces](#3-github-codespaces)** | Team consistency | GitHub account | Cloud development environment | | |
| | **[Dev Container](#4-vs-code-dev-container)** | Standardized tooling | Docker Desktop + VS Code | Containerized consistency | | |
| | **[GitHub Actions](#5-github-actions-cicd)** | Automated CI/CD | Service principal setup | Production deployments | |
docs/DeploymentGuideFabric.md
Outdated
| 1. Go to the [repository](https://github.com/microsoft/unified-data-foundation-with-fabric-solution-accelerator) | ||
| 2. Click **Code** → **Codespaces** → **Create codespace** | ||
|
|
||
| **Deployment**: Install azd and run [Quick Start commands](#quick-start) with device authentication: |
Copilot
AI
Dec 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The anchor link #quick-start is incorrect. The heading ## 🚀 Quick Start generates the anchor #-quick-start (emoji becomes a dash). This should be updated to #-quick-start to match the actual heading anchor.
| **Deployment**: Install azd and run [Quick Start commands](#quick-start) with device authentication: | |
| **Deployment**: Install azd and run [Quick Start commands](#-quick-start) with device authentication: |
docs/SetupDatabricks.md
Outdated
| 2. **Find the storage path URL:** | ||
| - Go to the [Azure Portal](https://portal.azure.com/). | ||
| - Navigate to your Azure Databricks resource group. | ||
| - Locate and click on the **Managed Resource Group**, |
Copilot
AI
Dec 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a punctuation error at the end of this line. The comma should be a period since this completes the instruction.
| - Locate and click on the **Managed Resource Group**, | |
| - Locate and click on the **Managed Resource Group**. |
Fixed punctuation in instructions for locating Managed Resource Group and Access Connector.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Updated the storage path URL format to include an optional path.
|
|
||
| ## Quick Manual Deployment | ||
|
|
||
| ### 1. Set Environment Variables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these instructions not required ?
Users may not be aware about how to set these.
| python --version | ||
| ``` | ||
|
|
||
| ## 🚀 Quick Start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this step should come after the Deployment Options, I see from deployment options we are navigating back to this step rather we should move forward.
Purpose
Documentation structure and usability improvements:
docs/DeploymentGuideFabric.md, outlining key sections and providing direct links for easier access to relevant content.Clarity and accuracy enhancements:
Consistency and troubleshooting updates:
docs/DeploymentGuideFabric.md, making the document easier to scan and reference. [1] [2] [3]Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information