Use dedicated "plugins" property in package.json for plugin loading #8889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generator currently scans all
dependenciesin package.json to discover plugins. This prevents throwing errors when plugin DLLs are missing since regular dependencies can't be distinguished from plugins.Changes
GeneratorHandler.cs: Modified
GetOrderedPluginDllsto:pluginsproperty instead ofdependenciesInvalidOperationExceptionwhen plugin dist directory or DLLs are not foundpluginsproperty exists (backward compatible)GeneratorHandlerTests.cs: Added tests for:
pluginspropertyMigration
Projects using plugins must move plugin entries from
dependenciesto a top-levelpluginsproperty. Regular dependencies remain independencies.Original prompt
<issue_description>Currently, we look under dependencies in package.json for any plugins. This is problematic because the plugins need to be built, and the generator doesn't know what dep is supposed to be a plugin so it can't throw if there is no dll found. We should instead adopt a new convention where we add a top-level property, called "plugins" and look there for any plugins. This would allow us to throw if we don't find a dll for the specified by plugin preventing downstream bugs.</issue_description>
Comments on the Issue (you are @copilot in this section)
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.