-
Notifications
You must be signed in to change notification settings - Fork 323
[typespec-vscode] show NoTarget diagnostic message in vscode #8757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[typespec-vscode] show NoTarget diagnostic message in vscode #8757
Conversation
commit: |
|
All changed packages have been documented.
|
|
You can try these changes here
|
| let message = diagnostic.message; | ||
| if (root === undefined) { | ||
| let emitterName: string | undefined = undefined; | ||
| if (diagnostic.code === "import-not-found") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this 'if' (import-not-found error) should include both tspconfig case and the ide settings case we want to have special handling. and the 'no associated location' should apply to all other cases as a fallback for other cases that no location found. Current code depending on emitterName makes the logic a little confusing.
Fix: #8539.
show NoTarget diagnostic message in vscode