Fix nil pointer panic in FormatOnEnter for if-else statements #2043
+61
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes panic when pressing Enter in TypeScript files containing if-else statements. The panic occurred when
FindPrecedingTokenreturnednilin edge cases, but the code only had a debug assertion (no-op in release builds) before dereferencing the pointer.Changes
childStartsOnTheSameLineWithElseInIfStatement: ReturnsfalsewhenFindPrecedingTokenreturnsnilinstead of dereferencing a nil pointerTestFormatOnEnter_NilPrecedingTokenvalidates the fix with multiple if-else edge casesOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.