Multiproject requests like find all refs, rename and workspace symbols #1991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheetalkamat
force-pushed
the
multiProject
branch
5 times, most recently
from
46a8abe to
f66df9c
Compare
Also remove unnecessary program update when doing gc on projects
… with -v so we can diagnose which test is failing
sheetalkamat
force-pushed
the
multiProject
branch
from
97ecb11 to
72e09da
Compare
sheetalkamat
commented
Nov 4, 2025
| "gotest.tools/v3/assert" | ||
| ) | ||
|
|
||
| type testServer struct { |
Member
Author
There was a problem hiding this comment.
Added this to baseline the project state and watching stuff - also allows to not open all files and control which one to open instead of fourslash opening all files. (to control which project is open).
i havent yet ported tests for watching and lifetime of project but i will do that separately
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates test baselines to reflect improved formatting and line numbering consistency in the test output files. The changes normalize how JSON content and TypeScript code are displayed in baseline files, removing inconsistent indentation and adding proper line numbers to all content.
Key Changes
- Standardized line numbering for all file content in test baselines
- Normalized JSON formatting to use consistent indentation (4 spaces)
- Fixed indentation for TypeScript code blocks in test files
- Updated hash values in tsbuildinfo files to reflect the normalized content
Reviewed Changes
Copilot reviewed 100 out of 125 changed files in this pull request and generated 62 comments.
Show a summary per file
| File | Description |
|---|---|
| tsc/moduleResolution/alternateResult.js | Added line numbers to JSON package files and normalized their indentation |
| tsc/declarationEmit/when-using-Windows-paths-and-uppercase-letters.js | Standardized indentation for TypeScript source code and adjusted error column positions |
| tsbuildWatch/projectsBuilding/*.js | Normalized tsconfig.json indentation across multiple project building tests |
| tsbuildWatch/programUpdates/*.js | Updated file content formatting and corresponding hash values in tsbuildinfo |
| tsbuild/resolveJsonModule/*.js | Consistent JSON formatting for all tsconfig.json files |
| lspservertests/rename/*.js | Added complete baseline content for new rename test cases |
| lspservertests/findAllRefs/*.js | Added complete baseline content for new find all references test cases |
...s/reference/lspservertests/declarationMaps/findAllReferences-definition-is-in-mapped-file.js
Show resolved
Hide resolved
...selines/reference/lspservertests/declarationMaps/findAllReferences-starting-at-definition.js
Show resolved
Hide resolved
...aselines/reference/lspservertests/declarationMaps/findAllReferences-target-does-not-exist.js
Show resolved
Hide resolved
...rvertests/findAllRefs/special-handling-of-localness-when-using-method-of-class-expression.js
Show resolved
Hide resolved
...ervertests/findAllRefs/special-handling-of-localness-when-using-arrow-function-assignment.js
Show resolved
Hide resolved
...pservertests/findAllRefs/special-handling-of-localness-when-using-object-literal-property.js
Show resolved
Hide resolved
testdata/baselines/reference/lspservertests/rename/rename-in-common-file-renames-all-project.js
Show resolved
Hide resolved
testdata/baselines/reference/lspservertests/rename/ancestor-and-project-ref-management.js
Show resolved
Hide resolved
jakebailey
reviewed
Nov 5, 2025
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
Some comments; have not read the entire thing yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.