Fix crash by removing getNameFromImportDeclaration in favor of Node.Name() (#2027)

Author: ahejlsberg

internal/checker/checker.go

@@ -13987,7 +13987,7 @@ func (c *Checker) checkAndReportErrorForResolvingImportAliasToTypeOnlySymbol(nod
 		// TODO: how to get name for export *?
 		name := "*"
 		if !ast.IsExportDeclaration(typeOnlyDeclaration) {
-			name = getNameFromImportDeclaration(typeOnlyDeclaration).Text()
+			name = typeOnlyDeclaration.Name().Text()
 		}
 		c.error(decl.ModuleReference, message).AddRelatedInfo(createDiagnosticForNode(typeOnlyDeclaration, relatedMessage, name))
 	}

internal/checker/utilities.go

@@ -189,20 +189,6 @@ func IsInTypeQuery(node *ast.Node) bool {
 	}) != nil
 }
 
-func getNameFromImportDeclaration(node *ast.Node) *ast.Node {
-	switch node.Kind {
-	case ast.KindImportSpecifier:
-		return node.AsImportSpecifier().Name()
-	case ast.KindNamespaceImport:
-		return node.AsNamespaceImport().Name()
-	case ast.KindImportClause:
-		return node.AsImportClause().Name()
-	case ast.KindImportEqualsDeclaration:
-		return node.AsImportEqualsDeclaration().Name()
-	}
-	return nil
-}
-
 func nodeCanBeDecorated(useLegacyDecorators bool, node *ast.Node, parent *ast.Node, grandparent *ast.Node) bool {
 	// private names cannot be used with decorators yet
 	if useLegacyDecorators && node.Name() != nil && ast.IsPrivateIdentifier(node.Name()) {

testdata/baselines/reference/compiler/importAliasTypeOnlyExport.errors.txt

@@ -0,0 +1,14 @@
+t.ts(2,14): error TS1379: An import alias cannot reference a declaration that was exported using 'export type'.
+
+
+==== t.ts (1 errors) ====
+    import a = require("./a");
+    import foo = a.Foo
+                 ~~~~~
+!!! error TS1379: An import alias cannot reference a declaration that was exported using 'export type'.
+!!! related TS1377 a.ts:2:15: 'Foo' was exported here.
+    
+==== a.ts (0 errors) ====
+    type Foo = { x: number }
+    export type { Foo };
+    

testdata/baselines/reference/compiler/importAliasTypeOnlyExport.symbols

@@ -0,0 +1,19 @@
+//// [tests/cases/compiler/importAliasTypeOnlyExport.ts] ////
+
+=== t.ts ===
+import a = require("./a");
+>a : Symbol(a, Decl(t.ts, 0, 0))
+
+import foo = a.Foo
+>foo : Symbol(foo, Decl(t.ts, 0, 26))
+>a : Symbol(a, Decl(t.ts, 0, 0))
+>Foo : Symbol(a.Foo, Decl(a.ts, 1, 13))
+
+=== a.ts ===
+type Foo = { x: number }
+>Foo : Symbol(Foo, Decl(a.ts, 0, 0))
+>x : Symbol(x, Decl(a.ts, 0, 12))
+
+export type { Foo };
+>Foo : Symbol(Foo, Decl(a.ts, 1, 13))
+

testdata/baselines/reference/compiler/importAliasTypeOnlyExport.types

@@ -0,0 +1,19 @@
+//// [tests/cases/compiler/importAliasTypeOnlyExport.ts] ////
+
+=== t.ts ===
+import a = require("./a");
+>a : typeof a
+
+import foo = a.Foo
+>foo : any
+>a : typeof a
+>Foo : foo
+
+=== a.ts ===
+type Foo = { x: number }
+>Foo : Foo
+>x : number
+
+export type { Foo };
+>Foo : Foo
+

testdata/tests/cases/compiler/importAliasTypeOnlyExport.ts

@@ -0,0 +1,11 @@
+// @target: esnext
+// @module: commonjs
+// @noEmit: true
+
+// @filename: t.ts
+import a = require("./a");
+import foo = a.Foo
+
+// @filename: a.ts
+type Foo = { x: number }
+export type { Foo };