Properly include JSX attributes in find-all-references (#2025)

Author: ahejlsberg

internal/ls/utilities.go

@@ -1647,20 +1647,24 @@ func getContainingObjectLiteralElementWorker(node *ast.Node) *ast.Node {
 	switch node.Kind {
 	case ast.KindStringLiteral, ast.KindNoSubstitutionTemplateLiteral, ast.KindNumericLiteral:
 		if node.Parent.Kind == ast.KindComputedPropertyName {
-			if ast.IsObjectLiteralElement(node.Parent.Parent) {
+			if isObjectLiteralOrJsxElement(node.Parent.Parent) {
 				return node.Parent.Parent
 			}
 			return nil
 		}
 		fallthrough
 	case ast.KindIdentifier:
-		if ast.IsObjectLiteralElement(node.Parent) && (node.Parent.Parent.Kind == ast.KindObjectLiteralExpression || node.Parent.Parent.Kind == ast.KindJsxAttributes) && node.Parent.Name() == node {
+		if isObjectLiteralOrJsxElement(node.Parent) && (node.Parent.Parent.Kind == ast.KindObjectLiteralExpression || node.Parent.Parent.Kind == ast.KindJsxAttributes) && node.Parent.Name() == node {
 			return node.Parent
 		}
 	}
 	return nil
 }
 
+func isObjectLiteralOrJsxElement(node *ast.Node) bool {
+	return ast.IsObjectLiteralElement(node) || ast.IsJsxAttribute(node) || ast.IsJsxSpreadAttribute(node)
+}
+
 // Return a function that returns true if the given node has not been seen
 func nodeSeenTracker() func(*ast.Node) bool {
 	var seen collections.Set[*ast.Node]

testdata/baselines/reference/fourslash/findAllReferences/tsxFindAllReferences10.baseline.jsonc

@@ -8,4 +8,13 @@
 // }
 // interface LinkProps extends ClickableProps {
 //     goTo: string;
-// // --- (line: 16) skipped ---
+// }
+// declare function MainButton(buttonProps: ButtonProps): JSX.Element;
+// declare function MainButton(linkProps: LinkProps): JSX.Element;
+// declare function MainButton(props: ButtonProps | LinkProps): JSX.Element;
+// let opt = <MainButton />;
+// let opt = <MainButton children="chidlren" />;
+// let opt = <MainButton [|onClick|]={()=>{}} />;
+// let opt = <MainButton [|onClick|]={()=>{}} ignore-prop />;
+// let opt = <MainButton goTo="goTo" />;
+// let opt = <MainButton wrong />;

testdata/baselines/reference/fourslash/findAllReferences/tsxFindAllReferences2.baseline.jsonc

@@ -8,4 +8,6 @@
 //             isOpen?: boolean;
 //         };
 //         span: { n: string; };
-// // --- (line: 9) skipped ---
+//     }
+// }
+// var x = <div [|name|]="hello" />;

testdata/baselines/reference/fourslash/findAllReferences/tsxFindAllReferences3.baseline.jsonc

@@ -9,4 +9,4 @@
 // }
 // 
 // 
-// var x = <MyClass name='hello'/>;
+// var x = <MyClass [|name|]='hello'/>;

testdata/baselines/reference/fourslash/findAllReferences/tsxFindAllReferences7.baseline.jsonc

@@ -8,4 +8,8 @@
 //     propString: string
 //     optional?: boolean
 // }
-// // --- (line: 12) skipped ---
+// declare function Opt(attributes: OptionPropBag): JSX.Element;
+// let opt = <Opt />;
+// let opt1 = <Opt [|propx|]={100} propString />;
+// let opt2 = <Opt [|propx|]={100} optional/>;
+// let opt3 = <Opt wrong />;

testdata/baselines/reference/fourslash/findAllReferences/tsxFindAllReferences9.baseline.jsonc

@@ -8,4 +8,11 @@
 // }
 // declare function MainButton(buttonProps: ButtonProps): JSX.Element;
 // declare function MainButton(linkProps: LinkProps): JSX.Element;
-// // --- (line: 19) skipped ---
+// declare function MainButton(props: ButtonProps | LinkProps): JSX.Element;
+// let opt = <MainButton />;
+// let opt = <MainButton children="chidlren" />;
+// let opt = <MainButton onClick={()=>{}} />;
+// let opt = <MainButton onClick={()=>{}} ignore-prop />;
+// let opt = <MainButton [|goTo|]="goTo" />;
+// let opt = <MainButton [|goTo|] />;
+// let opt = <MainButton wrong />;

testdata/baselines/reference/submodule/fourslash/findRenameLocations/tsxRename2.baseline.jsonc

@@ -8,13 +8,21 @@
 //             isOpen?: boolean;
 //         };
 //         span: { n: string; };
-// // --- (line: 9) skipped ---
+//     }
+// }
+// var x = <div [|nameRENAME|]="hello" />;
 
 
 
 // === findRenameLocations ===
 // === /file.tsx ===
-// --- (line: 7) skipped ---
+// declare module JSX {
+//     interface Element { }
+//     interface IntrinsicElements {
+//         div: {
+//             [|nameRENAME|]?: string;
+//             isOpen?: boolean;
+//         };
 //         span: { n: string; };
 //     }
 // }

testdata/baselines/reference/submodule/fourslash/findRenameLocations/tsxRename2.baseline.jsonc.diff

@@ -9,13 +9,18 @@
 // }
 // 
 // 
-// var x = <MyClass name='hello'/>;
+// var x = <MyClass [|nameRENAME|]='hello'/>;
 
 
 
 // === findRenameLocations ===
 // === /file.tsx ===
-// --- (line: 10) skipped ---
+// --- (line: 5) skipped ---
+// }
+// class MyClass {
+//   props: {
+//     [|nameRENAME|]?: string;
+//     size?: number;
 // }
 // 
 //