Skip to content

Adds Object Display Name to Visual Filter, Page Filter, and Report Filter categories #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adds Object Display Name to Visual Filter, Page Filter, and Report Filter categories #988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/sempy_labs/report/_reportwrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -772,6 +772,7 @@ def list_report_filters(self, extended: bool = False) -> pd.DataFrame:
"Table Name": "str",
"Object Name": "str",
"Object Type": "str",
"Object Display Name": "str",
"Hidden": "bool",
"Locked": "bool",
"How Created": "str",
Expand All @@ -789,6 +790,7 @@ def list_report_filters(self, extended: bool = False) -> pd.DataFrame:
hidden = flt.get("isHiddenInViewMode", False)
filter_type = flt.get("type", "Basic")
filter_used = True if "Where" in flt.get("filter", {}) else False
obj_display_name = flt.get("displayName")

entity_property_pairs = helper.find_entity_property_pairs(flt)

Expand All @@ -800,6 +802,7 @@ def list_report_filters(self, extended: bool = False) -> pd.DataFrame:
"Table Name": properties[0],
"Object Name": object_name,
"Object Type": properties[1],
"Object Display Name": obj_display_name,
"Hidden": hidden,
"Locked": locked,
"How Created": how_created,
Expand Down Expand Up @@ -841,6 +844,7 @@ def list_page_filters(self, extended: bool = False) -> pd.DataFrame:
"Table Name": "str",
"Object Name": "str",
"Object Type": "str",
"Object Display Name": "str",
"Hidden": "bool",
"Locked": "bool",
"How Created": "str",
Expand All @@ -862,6 +866,7 @@ def list_page_filters(self, extended: bool = False) -> pd.DataFrame:
hidden = flt.get("isHiddenInViewMode", False)
filter_type = flt.get("type", "Basic")
filter_used = True if "Where" in flt.get("filter", {}) else False
obj_display_name = flt.get("displayName")

entity_property_pairs = helper.find_entity_property_pairs(flt)

Expand All @@ -875,6 +880,7 @@ def list_page_filters(self, extended: bool = False) -> pd.DataFrame:
"Table Name": properties[0],
"Object Name": object_name,
"Object Type": properties[1],
"Object Display Name": obj_display_name,
"Hidden": hidden,
"Locked": locked,
"How Created": how_created,
Expand Down Expand Up @@ -918,6 +924,7 @@ def list_visual_filters(self, extended: bool = False) -> pd.DataFrame:
"Table Name": "str",
"Object Name": "str",
"Object Type": "str",
"Object Display Name": "str",
"Hidden": "bool",
"Locked": "bool",
"How Created": "str",
Expand All @@ -943,6 +950,7 @@ def list_visual_filters(self, extended: bool = False) -> pd.DataFrame:
hidden = flt.get("isHiddenInViewMode", False)
filter_type = flt.get("type", "Basic")
filter_used = True if "Where" in flt.get("filter", {}) else False
obj_display_name = flt.get("displayName")

entity_property_pairs = helper.find_entity_property_pairs(flt)

Expand All @@ -957,6 +965,7 @@ def list_visual_filters(self, extended: bool = False) -> pd.DataFrame:
"Table Name": properties[0],
"Object Name": object_name,
"Object Type": properties[1],
"Object Display Name": obj_display_name,
"Hidden": hidden,
"Locked": locked,
"How Created": how_created,
Expand Down