Adding fix for Manual set value clearTextOnSubmit-style behavior not working on Fabric #15277

protikbiswas100 · 2025-10-23T05:25:36Z

Description

TextInput regression between Paper and Fabric: Manual set value clearTextOnSubmit-style behavior not working

Type of Change

Bug fix (non-breaking change which fixes an issue)

Why

The issue is that JavaScript receives onSubmitEditing with eventCount N, but when it immediately calls setValue(''), native has already moved to N+1, so the JS command gets rejected. This causes mismatch between JS and Native side

Resolves [https://github.com//issues/15168]

What

The issue is that JavaScript receives onSubmitEditing with eventCount N, but when it immediately calls setValue('') native has already moved to N+1, so the JS command gets rejected. To fix the issue the solution taken is don't increment the event count until AFTER the JavaScript has had a chance to respond to the submit event.

Screenshots

Before

15168-before.mp4

After

15168-after.mp4

Testing

yarn build passed successfully, added a sample textInput field in RNTester-Fabric app to repro the issue.

Ran E2ETestAppFabric Unit Test

Changelog

Should this change be included in the release notes: yes

Added synchroinization logic betwwen JS and native layer onClearSubmit is not working

Microsoft Reviewers: Open in CodeFlow

protikbiswas100 · 2025-10-23T05:25:50Z

/azp run

azure-pipelines · 2025-10-23T05:26:03Z

Azure Pipelines successfully started running 2 pipeline(s).

protikbiswas100 · 2025-10-23T05:26:47Z

/azp run

azure-pipelines · 2025-10-23T05:27:05Z

Azure Pipelines successfully started running 2 pipeline(s).

Copilot

Pull Request Overview

This PR fixes a regression in TextInput behavior between Paper and Fabric architectures where manual value clearing on submit (clearTextOnSubmit-style behavior) was not working correctly. The issue occurred when JavaScript immediately updated the text value during onSubmitEditing, causing synchronization problems between native and JS state.

Key Changes:

Modified event count validation to accept immediate JS updates by changing the condition from eventCount >= m_nativeEventCount to eventCount >= m_nativeEventCount - 1
Added state synchronization when clearing text to ensure React state stays consistent with native TextInput state

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
`vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp`	Modified event count check and added state update logic when clearing text on submit
`change/react-native-windows-daac39ef-4292-4f66-81ae-708b1c0f6676.json`	Added change file for versioning

vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp

change/react-native-windows-daac39ef-4292-4f66-81ae-708b1c0f6676.json

…76.json Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

anupriya13 · 2025-10-23T06:26:55Z

In the video when you pressed enter in last text input why did it have the value "backslash" instead of empty?

protikbiswas100 · 2025-10-23T06:28:43Z

In the video when you pressed enter in last text input why did it have the value "backslash" instead of empty?

I pressed back slash key by mistake after pressing enter from my keyboard

vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp

protikbiswas100 · 2025-10-23T06:29:55Z

/azp run

azure-pipelines · 2025-10-23T06:30:09Z

Azure Pipelines successfully started running 2 pipeline(s).

anupriya13 · 2025-10-23T06:30:16Z

In the video when you pressed enter in last text input why did it have the value "backslash" instead of empty?

I pressed back slash key by mistake after pressing enter from my keyboard

Okay can you please re-record and attach correct before and after videos?

anupriya13 · 2025-10-23T06:31:42Z

Description Summary missing in the end.
"Add a brief summary of the change to use in the release notes for the next release."

anupriya13 · 2025-10-23T06:33:13Z

E2ETestAppFabric Unit Test verification?

vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp

protikbiswas100 · 2025-10-27T06:38:45Z

In the video when you pressed enter in last text input why did it have the value "backslash" instead of empty?

I pressed back slash key by mistake after pressing enter from my keyboard

Okay can you please re-record and attach correct before and after videos?

reuploaded before and after videos

protikbiswas100 · 2025-10-27T06:43:21Z

E2ETestAppFabric Unit Test verification

Added in next commit

protikbiswas100 · 2025-10-27T06:44:20Z

Description Summary missing in the end. "Add a brief summary of the change to use in the release notes for the next release."

It's already there in description

…react-native-windows into textInput-15168

protikbiswas100 · 2025-10-30T08:30:23Z

/azp run

azure-pipelines · 2025-10-30T08:30:37Z

Azure Pipelines successfully started running 2 pipeline(s).

protikbiswas100 · 2025-11-04T07:10:31Z

/azp run

azure-pipelines · 2025-11-04T07:10:50Z

Azure Pipelines successfully started running 2 pipeline(s).

protikbiswas100 · 2025-11-04T08:27:06Z

/azp run

azure-pipelines · 2025-11-04T08:27:24Z

Azure Pipelines successfully started running 2 pipeline(s).

protikbiswas100 · 2025-11-05T02:08:44Z

/azp run

azure-pipelines · 2025-11-05T02:09:01Z

Azure Pipelines successfully started running 2 pipeline(s).

…vent count

protikbiswas100 · 2025-11-05T02:17:30Z

/azp run

azure-pipelines · 2025-11-05T02:17:50Z

Azure Pipelines successfully started running 2 pipeline(s).

protikbiswas100 · 2025-11-05T02:39:31Z

/azp run

azure-pipelines · 2025-11-05T02:39:45Z

Azure Pipelines successfully started running 2 pipeline(s).

protikbiswas100 · 2025-11-05T03:14:16Z

/azp run

azure-pipelines · 2025-11-05T03:14:30Z

Azure Pipelines successfully started running 2 pipeline(s).

protikbiswas100 · 2025-11-05T03:29:08Z

/azp run

azure-pipelines · 2025-11-05T03:29:23Z

Azure Pipelines successfully started running 2 pipeline(s).

acoates-ms · 2025-11-05T03:46:09Z

This same issue seems to repro on iOS. So I think we can wont fix this issue.

Protik Biswas added 2 commits October 23, 2025 10:53

adding fix for TextInput

d9ad94e

Change files

0e83625

protikbiswas100 requested a review from a team as a code owner October 23, 2025 05:25

Merge branch 'main' into textInput-15168

8dde8cc

protikbiswas100 mentioned this pull request Oct 23, 2025

TextInput regression between Paper and Fabric: Manual set value clearTextOnSubmit-style behavior not working. #15168

Closed

anupriya13 requested a review from Copilot October 23, 2025 06:22

Copilot AI reviewed Oct 23, 2025

View reviewed changes

vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp Outdated Show resolved Hide resolved

change/react-native-windows-daac39ef-4292-4f66-81ae-708b1c0f6676.json Outdated Show resolved Hide resolved

Update change/react-native-windows-daac39ef-4292-4f66-81ae-708b1c0f66…

da2a4bf

…76.json Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

anupriya13 reviewed Oct 23, 2025

View reviewed changes

vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp Outdated Show resolved Hide resolved

acoates-ms reviewed Oct 23, 2025

View reviewed changes

vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp Outdated Show resolved Hide resolved

Protik Biswas added 4 commits October 27, 2025 12:55

changed logic for native and js side event count

13473ed

Merge branch 'textInput-15168' of https://github.com/protikbiswas100/…

4c8e428

…react-native-windows into textInput-15168

adding formatting changes

8771b9e

adding linting fix

66e141d

removing e2e test

2068ef7

protikbiswas100 force-pushed the textInput-15168 branch from 91e1cdd to 2068ef7 Compare November 4, 2025 08:26

Merge branch 'main' into textInput-15168

ab4fa57

changing synchronization logic between JS and Native side

6d1a24b

changing logic to avoid some difference between JS and Native layer e…

73dc3d1

…vent count

protikbiswas100 force-pushed the textInput-15168 branch from ebb1b41 to 73dc3d1 Compare November 5, 2025 02:16

protikbiswas100 requested a review from acoates-ms November 5, 2025 02:20

adding format change

877fd6a

protikbiswas100 force-pushed the textInput-15168 branch from 07a9743 to 877fd6a Compare November 5, 2025 02:39

adding header and adding new field

b1ef624

protikbiswas100 force-pushed the textInput-15168 branch from 4fdf14e to b1ef624 Compare November 5, 2025 03:13

fixing linting issue

802abdf

protikbiswas100 force-pushed the textInput-15168 branch from 3f9b801 to 802abdf Compare November 5, 2025 03:28

Merge branch 'main' into textInput-15168

ce7cb97

protikbiswas100 closed this Nov 5, 2025

Adding fix for Manual set value clearTextOnSubmit-style behavior not working on Fabric #15277

Adding fix for Manual set value clearTextOnSubmit-style behavior not working on Fabric #15277

Uh oh!

Conversation

protikbiswas100 commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

Why

What

Screenshots

Testing

Changelog

Microsoft Reviewers: Open in CodeFlow

Microsoft Reviewers: Open in CodeFlow

Uh oh!

protikbiswas100 commented Oct 23, 2025

Uh oh!

azure-pipelines bot commented Oct 23, 2025

Uh oh!

protikbiswas100 commented Oct 23, 2025

Uh oh!

azure-pipelines bot commented Oct 23, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

anupriya13 commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

protikbiswas100 commented Oct 23, 2025

Uh oh!

Uh oh!

protikbiswas100 commented Oct 23, 2025

Uh oh!

azure-pipelines bot commented Oct 23, 2025

Uh oh!

anupriya13 commented Oct 23, 2025

Uh oh!

anupriya13 commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anupriya13 commented Oct 23, 2025

Uh oh!

Uh oh!

protikbiswas100 commented Oct 27, 2025

Uh oh!

protikbiswas100 commented Oct 27, 2025

Uh oh!

protikbiswas100 commented Oct 27, 2025

Uh oh!

protikbiswas100 commented Oct 30, 2025

Uh oh!

azure-pipelines bot commented Oct 30, 2025

Uh oh!

protikbiswas100 commented Nov 4, 2025

Uh oh!

azure-pipelines bot commented Nov 4, 2025

Uh oh!

protikbiswas100 commented Nov 4, 2025

Uh oh!

azure-pipelines bot commented Nov 4, 2025

Uh oh!

protikbiswas100 commented Nov 5, 2025

Uh oh!

azure-pipelines bot commented Nov 5, 2025

Uh oh!

protikbiswas100 commented Nov 5, 2025

Uh oh!

azure-pipelines bot commented Nov 5, 2025

Uh oh!

protikbiswas100 commented Nov 5, 2025

Uh oh!

azure-pipelines bot commented Nov 5, 2025

Uh oh!

protikbiswas100 commented Nov 5, 2025

protikbiswas100 commented Oct 23, 2025 •

edited

Loading

anupriya13 commented Oct 23, 2025 •

edited

Loading

anupriya13 commented Oct 23, 2025 •

edited

Loading