Rename pub_key field in telemetry (#2503) #2509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pub_key field in the OpenHCL telemetry is raising false-positive alerts for credential disclosure. Rename it to something that won't trigger alerts.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a security scanning false-positive by renaming the pub_key telemetry field to akpub_hash in OpenHCL's TPM device implementation. The field logs a base64-encoded SHA256 hash of the Attestation Key (AK) public key for auditing purposes.
Key Changes
- Renamed telemetry field from
pub_keytoakpub_hashacross 5 logging locations - The actual data being logged (base64-encoded SHA256 hash) remains unchanged
- Change helps avoid triggering credential disclosure alerts in security scanning tools
Copilot suggested a better name; let's use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pub_key field in the OpenHCL telemetry is raising false-positive alerts for credential disclosure. Rename it to something that won't trigger alerts.