mana: enable mana keepalive by default for tests #2461
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables MANA keepalive by default for all tests, making it consistent with NVMe keepalive behavior. Unlike NVMe keepalive which is added to the boot command line by OpenHCL boot, MANA keepalive requires explicit configuration through the petri test framework.
Key changes:
- Default servicing flags now enable MANA keepalive for OpenVMM backend
- MANA keepalive command line parameter automatically added to all test configurations
- Test no longer needs to explicitly set MANA keepalive parameters
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vmm_tests/vmm_tests/tests/tests/multiarch/openhcl_servicing.rs | Removes explicit MANA keepalive command line setting from test, now uses default configuration |
| petri/src/vm/openvmm/mod.rs | Sets enable_mana_keepalive to true in default servicing flags for OpenVMM backend |
| petri/src/vm/mod.rs | Adds OPENHCL_MANA_KEEP_ALIVE=host,privatepool to OpenHCL command line by default for all tests |
justus-camp-microsoft
force-pushed
the
enable_mana_ka_for_all_tests
branch
from
0d03e4f to
912ae81
Compare
Contributor
|
Nice. This looks good, and glad that it caught a bug. |
justus-camp-microsoft
added a commit
that referenced
this pull request
Dec 2, 2025
#2461 found a bug in MANA's keepalive implementation, where we can race on an empty collection which results in a divide by zero in futures-concurrency. This checks for that condition and returns early if there are no endpoints configured.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to be an equivalent change for MANA to #2401, but with some minor differences. NVMe keepalive is added to the boot cmdline by default but MANA keepalive is not, so this adds it to petri's command line builder.