Improves implementation of aten_index_put #2641
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… xadupre/input_put
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2641 +/- ##
=======================================
Coverage 70.43% 70.44%
=======================================
Files 224 224
Lines 26778 26863 +85
Branches 2680 2697 +17
=======================================
+ Hits 18862 18924 +62
- Misses 6985 6998 +13
- Partials 931 941 +10 ☔ View full report in Codecov by Sentry. |
gramalingam
reviewed
Oct 27, 2025
gramalingam
reviewed
Oct 27, 2025
Collaborator
|
Adding some pointers/info for my own clarification: |
gramalingam
reviewed
Nov 7, 2025
| expand_value_shape = [] | ||
| for i, ind in enumerate(indices): | ||
| if isinstance(ind, torch.onnx._internal.exporter._tensors.SymbolicTensor): # pylint: disable=protected-access | ||
| ind.dtype = ir.DataType.INT64 |
Collaborator
There was a problem hiding this comment.
Why do we need the above line? Just wondering ... shouldn't it already have dtype set?
Member
Author
There was a problem hiding this comment.
Maybe it is not useful anymore but when I did this PR, it was needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #2606.