-
Notifications
You must be signed in to change notification settings - Fork 221
Add UnifiedMessage support for iperf3 TCP and UDP performance metrics #4058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
6
commits into
main
Choose a base branch
from
copilot/add-unified-message-network-tcp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: squirrelsc <27178119+squirrelsc@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add UnifiedMessage for all NetworkTCPPerformanceMessage
Add UnifiedMessage support for iperf3 TCP and UDP performance metrics
Oct 20, 2025
Copilot finished work on behalf of
squirrelsc
October 20, 2025 21:52
squirrelsc
reviewed
Oct 21, 2025
…ions_num as parameter Co-authored-by: squirrelsc <27178119+squirrelsc@users.noreply.github.com>
Copilot finished work on behalf of
squirrelsc
October 21, 2025 01:18
squirrelsc
reviewed
Oct 21, 2025
Member
squirrelsc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot resolve conflicts with main branch
…essage-network-tcp
…r_size metrics Co-authored-by: squirrelsc <27178119+squirrelsc@users.noreply.github.com>
Contributor
Author
Merged main branch successfully. The merge added MetricRelativity.Parameter enum which is now used for parameter-type metrics. (commit 59068fe) |
Copilot finished work on behalf of
squirrelsc
October 21, 2025 01:48
squirrelsc
reviewed
Oct 21, 2025
Co-authored-by: squirrelsc <27178119+squirrelsc@users.noreply.github.com>
Member
|
@LiliDeng LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unified performance message support to the iperf3 tool, bringing it into alignment with the existing pattern established by ntttcp. Previously, iperf3 only sent traditional
NetworkTCPPerformanceMessageandNetworkUDPPerformanceMessage, while ntttcp sent both traditional messages and unified performance messages for better analytics and standardization.Changes Made
Core Implementation
MetricRelativity,TransportProtocol, andsend_unified_perf_messageto iperf3.py_send_unified_perf_metrics()- Sends unified performance metrics following the established patternsend_iperf3_tcp_unified_perf_messages()- Sends unified messages for TCP performance metricssend_iperf3_udp_unified_perf_messages()- Sends unified messages for UDP performance metricsTCP Metrics Sent
connections_num(Parameter) - Number of concurrent connectionsrx_throughput_in_gbps(HigherIsBetter) - Receive throughputtx_throughput_in_gbps(HigherIsBetter) - Transmit throughputbuffer_size_bytes(Parameter) - Buffer size configurationcongestion_windowsize_kb(HigherIsBetter) - TCP congestion window sizeretransmitted_segments(LowerIsBetter) - Number of retransmitted segmentsUDP Metrics Sent
connections_num(Parameter) - Number of concurrent connectionstx_throughput_in_gbps(HigherIsBetter) - Transmit throughputrx_throughput_in_gbps(HigherIsBetter) - Receive throughputdata_loss(LowerIsBetter) - Packet loss percentagesend_buffer_size(Parameter) - Send buffer size configurationPattern Alignment with Main Branch
rx_throughput_in_gbpsinstead ofrx_throughput_in_gbps_conn_1)other_fieldsto avoid redundant JSON parsingIntegration
Updated the existing message creation methods to call the unified message senders:
create_iperf_tcp_performance_message()now callssend_iperf3_tcp_unified_perf_messages()create_iperf_udp_performance_message()now callssend_iperf3_udp_unified_perf_messages()Benefits
MetricRelativity.Parameterfor better data categorizationTesting
Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.