Skip to content

Conversation

@dluc
Copy link
Collaborator

@dluc dluc commented Dec 2, 2025

Summary

This PR consolidates code analysis configuration and updates dependencies:

  • Removed temporary analyzer configuration files that were used during development (src/Core/.editorconfig, src/Core/GlobalSuppressions.cs)
  • Consolidated code analysis rules into main .editorconfig with pragmatic severity levels
  • Updated dependencies: Spectre.Console (0.49.1 → 0.54.0/0.53.1), YamlDotNet (16.2.0 → 16.3.0)
  • Fixed CLI command signatures to match updated Spectre.Console API (added CancellationToken parameter)
  • Applied code quality fixes including culture-aware string formatting

Changes

Configuration

  • Removed temporary src/Core/.editorconfig and src/Core/GlobalSuppressions.cs files
  • Consolidated all analyzer rules into main src/.editorconfig
  • Disabled overly strict analyzer rules that conflicted with project patterns:
    • CA1031 (catch general exceptions) - needed for top-level error handling
    • CA1859 (concrete return types) - visitor pattern requires base types
    • RCS1141 (param documentation) - reduced noise during development
    • RCS1211 (unnecessary else) - style preference
    • CA1307/CA1308 - intentional string comparison behavior

Dependencies

  • Spectre.Console: 0.49.1 → 0.54.0
  • Spectre.Console.Cli: 0.49.1 → 0.53.1
  • YamlDotNet: 16.2.0 → 16.3.0

Code Fixes

  • Added CancellationToken parameter to all CLI command ExecuteAsync methods (breaking API change in Spectre.Console)
  • Added CultureInfo.CurrentCulture to ToString() call in MongoJsonQueryParser.cs:325
  • Updated using statements and removed redundant suppressions
  • General code style improvements

Test Plan

  • build.sh passes with 0 warnings/errors
  • format.sh passes
  • coverage.sh passes with 83.82% coverage (threshold 80%)
  • All 503 tests pass (289 Core + 214 Main)
  • Zero skipped tests

Related

Cleanup after #1098 (search command implementation)

- Remove temporary analyzer config files (Core/.editorconfig, GlobalSuppressions.cs)
- Consolidate all rules into main .editorconfig with pragmatic severity levels
- Update dependencies: Spectre.Console 0.49.1→0.54.0, YamlDotNet 16.2.0→16.3.0
- Fix CLI command signatures for updated Spectre.Console API (add CancellationToken)
- Apply code quality fixes (culture-aware string formatting)

All tests pass (503/503), coverage 83.82% (threshold 80%)
@dluc dluc merged commit b22235d into microsoft:main Dec 2, 2025
3 checks passed
@dluc dluc deleted the chore1202 branch December 2, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant