Publish proposal for connect authorization layer #4767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Alan-Jowett
requested review from
LakshK98,
dthaler,
matthewige,
mikeagun,
mtfriesen,
poornagmsft,
saxena-anurag and
shankarseal
as code owners
dthaler
reviewed
Oct 29, 2025
dthaler
reviewed
Oct 29, 2025
added 3 commits
October 29, 2025 14:20
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
shankarseal
reviewed
Oct 30, 2025
| ```c | ||
| // CONNECT layer program - handles redirection and basic filtering. | ||
| SEC("cgroup/connect4") | ||
| int redirect_and_basic_filter(struct bpf_sock_addr *ctx) |
Collaborator
There was a problem hiding this comment.
bpf_sock_addr is writable for linux INET_CONNECT attach types. In the new attach type they are effectively not. Should the extension reject the verdict of a program at this attach layer that changed the sock_addr context by modifying the source or destiantion IP/port?
shankarseal
reviewed
Oct 30, 2025
| ### Additional Helper Functions | ||
| CONNECT_AUTHORIZATION and AUTH_RECV_ACCEPT attach types provide access to additional network layer properties through specialized helper functions: | ||
|
|
||
| #### `bpf_sock_addr_get_interface_type(ctx)` |
Collaborator
There was a problem hiding this comment.
Suggestion: a single helper function that returns a versioned struct that holds all the required information; with the provision new fields can be added for a future version.
dthaler
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add proposal only for connect authorization proposal.
Testing
N/A
Documentation
Yes
Installation
No.