Skip to content

Update test suite #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Update test suite #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 71 additions & 3 deletions src/feature-management/test/featureManager.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ describe("feature manager", () => {
expect(featureFlags[1]).to.eq("Beta");
});

it("should fail when feature flag is invalid", async () => {
it("should fail when feature flag id is invalid", async () => {
const dataSource = new Map();
dataSource.set("feature_management", {
feature_flags: [
Expand Down Expand Up @@ -111,7 +111,7 @@ describe("feature manager", () => {
]);
});

it("should evaluate features with conditions", () => {
it("should fail when feature flag is invalid", () => {
const dataSource = new Map();
dataSource.set("feature_management", {
feature_flags: [
Expand Down Expand Up @@ -178,6 +178,74 @@ describe("feature manager", () => {
]);
});

it("should evaluate features with conditions");
it("should evaluate client filters based on requirement type", () => {
const jsonObject = {
"feature_management": {
"feature_flags": [
{
"id": "AllFeature",
"enabled": true,
"conditions": {
"requirement_type": "All",
"client_filters": [
{
"name": "Microsoft.TimeWindow",
"parameters": {
"Start": "Tue, 4 Feb 2025 16:00:00 GMT"
}
},
{
"name": "Microsoft.Targeting",
"parameters": {
"Audience": {
"Users": [ "Alice" ],
"Exclusion": {
"Users": [ "Dave" ]
}
}
}
}
]
}
},
{
"id": "AnyFeature",
"enabled": true,
"conditions": {
// "requirement_type": "Any",
"client_filters": [
{
"name": "Microsoft.TimeWindow",
"parameters": {
"Start": "Tue, 4 Feb 2025 16:00:00 GMT"
}
},
{
"name": "Microsoft.Targeting",
"parameters": {
"Audience": {
"Users": [ "Alice" ],
"Exclusion": {
"Users": [ "Dave" ]
}
}
}
}
]
}
}
]
}
};

const provider = new ConfigurationObjectFeatureFlagProvider(jsonObject);
const featureManager = new FeatureManager(provider);
return Promise.all([
expect(featureManager.isEnabled("AllFeature", {userId: "Alice"})).eventually.eq(true),
expect(featureManager.isEnabled("AllFeature", {userId: "Dave"})).eventually.eq(false),
expect(featureManager.isEnabled("AnyFeature", {userId: "Dave"})).eventually.eq(true)
]);
});

it("should override default filters with custom filters");
});
Loading