Skip to content

Avoid seeking checks when decoding frames sequentially #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 12, 2025
Merged

Avoid seeking checks when decoding frames sequentially #1028

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3e9ae6f
Avoid seeking checks when decoding frames sequentially
NicolasHug Nov 7, 2025
86ec99e
Simplify seek skipping logic
NicolasHug Nov 11, 2025
e68d7ce
Merge branch 'main' of github.com:pytorch/torchcodec into avoid_seeki…
NicolasHug Nov 11, 2025
d98c78a
Merge branch 'simplify_skip' into avoid_seeking_checks
NicolasHug Nov 11, 2025
42409a9
comment
NicolasHug Nov 11, 2025
9acc148
Merge branch 'main' of github.com:pytorch/torchcodec into avoid_seeki…
NicolasHug Nov 12, 2025
2295241
Fix
NicolasHug Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/torchcodec/_core/SingleStreamDecoder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,9 +618,15 @@ FrameOutput SingleStreamDecoder::getFrameAtIndexInternal(
}
validateFrameIndex(streamMetadata, frameIndex);

int64_t pts = getPts(frameIndex);
setCursorPtsInSeconds(ptsToSeconds(pts, streamInfo.timeBase));
return getNextFrameInternal(preAllocatedOutputTensor);
// Only set cursor if we're not decoding sequentially
if (frameIndex != lastDecodedFrameIndex_ + 1) {
int64_t pts = getPts(frameIndex);
setCursorPtsInSeconds(ptsToSeconds(pts, streamInfo.timeBase));
}
Copy link
Contributor Author

@NicolasHug NicolasHug Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I included the changes from #1039 in this PR.

@scotts , does the comment make sense now? What the comment is not saying is why returning early in canWeAvoidSeeking() is important. It's important because it avoids the calls to av_index_search_timestamp which are potentially slow. I don't know if we want to get to that level of detail in the comment.

Copy link
Contributor

@scotts scotts Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this greatly helps with understanding.

I do think we should explain somewhere that canWeAvoidSeeking() is itself expensive in some circumstances. . That's deeply counter-intuitive, that the function we're calling as an optimization to avoid the slow thing is itself also a slow thing. (But hopefully less slow.) Perhaps that should belong at the top of canWeAvoidSeeking().

Copy link
Contributor Author

@NicolasHug NicolasHug Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will address that in an immediate follow-up


auto result = getNextFrameInternal(preAllocatedOutputTensor);
lastDecodedFrameIndex_ = frameIndex;
return result;
}

FrameBatchOutput SingleStreamDecoder::getFramesAtIndices(
Expand Down
1 change: 1 addition & 0 deletions src/torchcodec/_core/SingleStreamDecoder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,7 @@ class SingleStreamDecoder {
bool cursorWasJustSet_ = false;
int64_t lastDecodedAvFramePts_ = 0;
int64_t lastDecodedAvFrameDuration_ = 0;
int64_t lastDecodedFrameIndex_ = INT64_MIN;

// Stores various internal decoding stats.
DecodeStats decodeStats_;
Expand Down
Loading