Option to build oss faster until we remove these #1880
+20
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`controller` and `process_allocator` really are no longer needed to develop oss stuff, but we have to remove important testing, etc. For now, I just to be able to compile locally. This is a 3x build speed improvement because each of these binaries uses different flags for the underlying crates and causes recompiles. Differential Revision: [D86880713](https://our.internmc.facebook.com/intern/diff/D86880713/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86880713/)! [ghstack-poisoned]
meta-cla
bot
added
the
CLA Signed
`controller` and `process_allocator` really are no longer needed to develop oss stuff, but we have to remove important testing, etc. For now, I just to be able to compile locally. This is a 3x build speed improvement because each of these binaries uses different flags for the underlying crates and causes recompiles. Differential Revision: [D86880713](https://our.internmc.facebook.com/intern/diff/D86880713/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86880713/)! [ghstack-poisoned]
`controller` and `process_allocator` really are no longer needed to develop oss stuff, but we have to remove important testing, etc. For now, I just to be able to compile locally. This is a 3x build speed improvement because each of these binaries uses different flags for the underlying crates and causes recompiles. Differential Revision: [D86880713](https://our.internmc.facebook.com/intern/diff/D86880713/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86880713/)! [ghstack-poisoned]
`controller` and `process_allocator` really are no longer needed to develop oss stuff, but we have to remove important testing, etc. For now, I just to be able to compile locally. This is a 3x build speed improvement because each of these binaries uses different flags for the underlying crates and causes recompiles. Differential Revision: [D86880713](https://our.internmc.facebook.com/intern/diff/D86880713/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86880713/)! [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
controllerandprocess_allocatorreally are no longer needed to develop oss stuff, but we have to remove important testing, etc. For now, I just to be able to compile locally.This is a 3x build speed improvement because each of these binaries uses different flags for the underlying crates and causes recompiles.
Differential Revision: D86880713
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!