make supervision timeout message more user friendly #1873
+53
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: right now, when anything related to mesh agent happens, e.g. connection down, proc stopped, we print supervision error message like ``` monarch._rust_bindings.monarch_hyperactor.supervision.SupervisionError: Actor metatls:twshared12411.02.gtn2.facebook.com:36037,anon_0_15HL6RLpNvRw,agent[0] exited because of the following reason: <PyActorSupervisionEvent: metatls:twshared12411.02.gtn2.facebook.com:36037,anon_0_15HL6RLpNvRw,agent[0]: stopped at 2025-11-11 17:31:58.907237439 -08:00> ``` This message contains the actor mesh agent, which is monarch internal actor, should not be exposed to customers. This message would confuse users, thinking it is always something related to monarch internal. This diff changes the message to be more explicit for user what the next step is for investigation. New log for agent related error will look like ``` twshared234234.gtn3:23232 is not reacheable, check the log on the host for details ``` A followup diff will include a scuba link as part of the message, the scuba will show monarch error log and stderr error logs. Differential Revision: D86984496
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
right now, when anything related to mesh agent happens, e.g. connection down, proc stopped, we print supervision error message like
This message contains the actor mesh agent, which is monarch internal actor, should not be exposed to customers. This message would confuse users, thinking it is always something related to monarch internal.
This diff changes the message to be more explicit for user what the next step is for investigation. New log for agent related error will look like
A followup diff will include a scuba link as part of the message, the scuba will show monarch error log and stderr error logs.
Differential Revision: D86984496