Skip to content

Add better logging #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add better logging #1807

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions hyperactor_mesh/src/bootstrap.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,16 +218,18 @@ async fn exit_if_missed_heartbeat(bootstrap_index: usize, bootstrap_addr: Channe
Ok(tx) => tx,

Err(err) => {
// TODO: Log lifecycle state change in here.
tracing::error!(
"Failed to establish heartbeat connection to allocator, exiting! (addr: {:?}): {}",
"Failed to establish heartbeat connection from proc to allocator, exiting! (addr: {:?}): {}",
bootstrap_addr,
err
);
std::process::exit(1);
}
};
// TODO: Log lifecycle state change in here.
tracing::info!(
"Heartbeat connection established to allocator (idx: {bootstrap_index}, addr: {bootstrap_addr:?})",
"Heartbeat connection established from proc to allocator (idx: {bootstrap_index}, addr: {bootstrap_addr:?})",
);
loop {
RealClock.sleep(Duration::from_secs(5)).await;
Expand All @@ -240,11 +242,13 @@ async fn exit_if_missed_heartbeat(bootstrap_index: usize, bootstrap_addr: Channe
.await;

if let Err(err) = result {
// TODO: Log lifecycle state change in here.
tracing::error!(
"Heartbeat failed to allocator, exiting! (addr: {:?}): {}",
"Heartbeat failed to be sent from proc to allocator, exiting! (addr: {:?}): {}",
bootstrap_addr,
err
);
// TODO: Should there be a graceful exit here?
std::process::exit(1);
}
}
Expand Down
Loading