Skip to content

Conversation

@mariusae
Copy link
Member

@mariusae mariusae commented Nov 6, 2025

Stack from ghstack (oldest at bottom):

hyperactor::behavior! is expanded to support generic type parameters, allowing for parameterized behaviors.

We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write Controller<SomeMeshType>.

Mesh controllers should follow this behavior.

The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of Mesh.

Differential Revision: D86420507

NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!

`hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors.

We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`.

Mesh controllers should follow this behavior.

The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`.

Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)!

[ghstack-poisoned]
mariusae added a commit that referenced this pull request Nov 6, 2025
`hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors.

We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`.

Mesh controllers should follow this behavior.

The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`.

Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)!

ghstack-source-id: 321393645
Pull Request resolved: #1765
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 6, 2025
…ource behavior"

`hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors.

We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`.

Mesh controllers should follow this behavior.

The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`.

Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)!

[ghstack-poisoned]
mariusae added a commit that referenced this pull request Nov 6, 2025
Pull Request resolved: #1765

`hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors.

We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`.

Mesh controllers should follow this behavior.

The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`.

Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)!
ghstack-source-id: 321509089
…ource behavior"

`hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors.

We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`.

Mesh controllers should follow this behavior.

The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`.

Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)!

[ghstack-poisoned]
mariusae added a commit that referenced this pull request Nov 7, 2025
Pull Request resolved: #1765

`hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors.

We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`.

Mesh controllers should follow this behavior.

The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`.
ghstack-source-id: 321703406

Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)!
…ource behavior"

`hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors.

We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`.

Mesh controllers should follow this behavior.

The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`.

Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)!

[ghstack-poisoned]
mariusae added a commit that referenced this pull request Nov 11, 2025
Pull Request resolved: #1765

`hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors.

We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`.

Mesh controllers should follow this behavior.

The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`.
ghstack-source-id: 322469275

Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)!
…ource behavior"

`hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors.

We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`.

Mesh controllers should follow this behavior.

The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`.

Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)!

[ghstack-poisoned]
…ource behavior"

`hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors.

We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`.

Mesh controllers should follow this behavior.

The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`.

Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)!

[ghstack-poisoned]
…ource behavior"

`hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors.

We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`.

Mesh controllers should follow this behavior.

The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`.

Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)!

[ghstack-poisoned]
…ource behavior"

`hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors.

We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`.

Mesh controllers should follow this behavior.

The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`.

Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)!

[ghstack-poisoned]
…ource behavior"

`hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors.

We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`.

Mesh controllers should follow this behavior.

The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`.

Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)!

[ghstack-poisoned]
…ource behavior"

`hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors.

We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`.

Mesh controllers should follow this behavior.

The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`.

Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)!

[ghstack-poisoned]
…ource behavior"

`hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors.

We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`.

Mesh controllers should follow this behavior.

The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`.

Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)!

[ghstack-poisoned]
…ource behavior"

`hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors.

We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`.

Mesh controllers should follow this behavior.

The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`.

Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)!

[ghstack-poisoned]
…ource behavior"

`hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors.

We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`.

Mesh controllers should follow this behavior.

The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`.

Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)!

[ghstack-poisoned]
…ource behavior"

`hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors.

We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`.

Mesh controllers should follow this behavior.

The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`.

Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)!

[ghstack-poisoned]
…ource behavior"

`hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors.

We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`.

Mesh controllers should follow this behavior.

The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`.

Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)!

[ghstack-poisoned]
…ource behavior"

`hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors.

We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`.

Mesh controllers should follow this behavior.

The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`.

Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)!

[ghstack-poisoned]
@meta-codesync
Copy link

meta-codesync bot commented Nov 14, 2025

This pull request has been merged in f71631a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. fb-exported Merged meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants