-
Notifications
You must be signed in to change notification settings - Fork 107
[hyperactor] support generic behaviors; implement Mesh resource behavior #1765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors. We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`. Mesh controllers should follow this behavior. The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`. Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Nov 6, 2025
`hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors. We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`. Mesh controllers should follow this behavior. The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`. Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)! ghstack-source-id: 321393645 Pull Request resolved: #1765
…ource behavior" `hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors. We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`. Mesh controllers should follow this behavior. The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`. Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Nov 6, 2025
Pull Request resolved: #1765 `hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors. We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`. Mesh controllers should follow this behavior. The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`. Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)! ghstack-source-id: 321509089
…ource behavior" `hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors. We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`. Mesh controllers should follow this behavior. The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`. Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Nov 7, 2025
Pull Request resolved: #1765 `hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors. We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`. Mesh controllers should follow this behavior. The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`. ghstack-source-id: 321703406 Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)!
…ource behavior" `hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors. We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`. Mesh controllers should follow this behavior. The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`. Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Nov 11, 2025
Pull Request resolved: #1765 `hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors. We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`. Mesh controllers should follow this behavior. The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`. ghstack-source-id: 322469275 Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)!
…ource behavior" `hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors. We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`. Mesh controllers should follow this behavior. The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`. Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)! [ghstack-poisoned]
…ource behavior" `hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors. We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`. Mesh controllers should follow this behavior. The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`. Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)! [ghstack-poisoned]
…ource behavior" `hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors. We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`. Mesh controllers should follow this behavior. The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`. Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)! [ghstack-poisoned]
…ource behavior" `hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors. We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`. Mesh controllers should follow this behavior. The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`. Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)! [ghstack-poisoned]
…ource behavior" `hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors. We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`. Mesh controllers should follow this behavior. The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`. Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)! [ghstack-poisoned]
…ource behavior" `hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors. We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`. Mesh controllers should follow this behavior. The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`. Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)! [ghstack-poisoned]
…ource behavior" `hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors. We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`. Mesh controllers should follow this behavior. The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`. Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)! [ghstack-poisoned]
…ource behavior" `hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors. We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`. Mesh controllers should follow this behavior. The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`. Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)! [ghstack-poisoned]
…ource behavior" `hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors. We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`. Mesh controllers should follow this behavior. The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`. Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)! [ghstack-poisoned]
…ource behavior" `hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors. We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`. Mesh controllers should follow this behavior. The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`. Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)! [ghstack-poisoned]
…ource behavior" `hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors. We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`. Mesh controllers should follow this behavior. The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`. Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)! [ghstack-poisoned]
…ource behavior" `hyperactor::behavior!` is expanded to support generic type parameters, allowing for parameterized behaviors. We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write `Controller<SomeMeshType>`. Mesh controllers should follow this behavior. The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of `Mesh`. Differential Revision: [D86420507](https://our.internmc.facebook.com/intern/diff/D86420507/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86420507/)! [ghstack-poisoned]
|
This pull request has been merged in f71631a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
resource::Resource, and mesh::Mesh in terms of it #1841hyperactor::behavior!is expanded to support generic type parameters, allowing for parameterized behaviors.We use this new functionality to formally define what a mesh controller behavior is, by bundling related types into a trait, so that we can write
Controller<SomeMeshType>.Mesh controllers should follow this behavior.
The plan is then to expand this to a set of generic code, tools, and so on, that can be parameterized over different implementations of
Mesh.Differential Revision: D86420507
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!