Skip to content

Conversation

@jduerholt
Copy link
Collaborator

Motivation

Fixes the issue described in #3071.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Unit tests.

@meta-cla meta-cla bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 11, 2025
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.99%. Comparing base (4e7e903) to head (249bd9d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main    #3078      +/-   ##
===========================================
- Coverage   100.00%   99.99%   -0.01%     
===========================================
  Files          219      219              
  Lines        20879    20881       +2     
===========================================
+ Hits         20879    20880       +1     
- Misses           0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@hvarfner hvarfner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting test failure, but obviously unrelated. Thanks for fixing!

@meta-codesync
Copy link

meta-codesync bot commented Nov 11, 2025

@Balandat has imported this pull request. If you are a Meta employee, you can view this in D86792344.

@Balandat
Copy link
Contributor

Interesting test failure, but obviously unrelated.

@hvarner I would guess this is related to D86492815 / pytorch/pytorch#166335.

Would you mind taking care of this as part of your oncall shift? D86578948 resolves a similar issue.

@meta-codesync
Copy link

meta-codesync bot commented Nov 14, 2025

@Balandat merged this pull request in af48840.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants