-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
fix: resolve HTML entity handling inconsistency across diagram types #7110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
- Remove '#' from exclusion patterns in title and accessibility lexer rules - Affects multiple diagram parsers: journey, sequence, c4, gantt, requirement, etc. - Titles like 'Book mermaid-js#2: sous-titre' now parse correctly across all diagram types - Add comprehensive test suite to validate the fix Fixes mermaid-js#7105
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/layout-tidy-tree
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7110 +/- ##
==========================================
- Coverage 3.55% 3.55% -0.01%
==========================================
Files 473 474 +1
Lines 47480 47491 +11
Branches 730 730
==========================================
Hits 1687 1687
- Misses 45793 45804 +11
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
🐛 Description
Fixes inconsistent HTML entity handling where titles containing
#characters were truncated in some diagram types but not others.Issue: Titles like
"Book #2: sous-titre"worked in flowcharts but were truncated to"Book"in journey and sequence diagrams.🔍 Root Cause
Jison lexer rules in multiple parsers excluded
#characters from title parsing patterns using[^#\n;]+, causing text after#to be treated as comments and ignored.✅ Solution
#from exclusion patterns in title, acc_title, and acc_descr lexer rulesChanged Pattern Examples: