Skip to content

Conversation

@weitieda
Copy link
Contributor

@weitieda weitieda commented Sep 19, 2025

  1. It seems nice to have a scale bar to indicate the distance for user. MapKit comes with one for free.
  2. Fixed a MapKit location status check warning
Untitled.mp4
iShot_2025-09-19_16 15 38

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if i should commit these pod files. Feel free to let me know, it should be easy to be reverted.

@weitieda
Copy link
Contributor Author

Hello @merlos not sure if you saw this PR but in case not. : )

@merlos
Copy link
Owner

merlos commented Oct 12, 2025

Hello @merlos not sure if you saw this PR but in case not. : )

Hey!
Thank you @weitieda. Sorry I did not reply.
I saw it but did not have time to review and test it yet.
I'll need a few days more.

Thanks, Juan.

@weitieda weitieda force-pushed the master branch 3 times, most recently from 04b259f to 93e20d4 Compare October 12, 2025 21:27
@weitieda
Copy link
Contributor Author

Hello @merlos not sure if you saw this PR but in case not. : )

Hey! Thank you @weitieda. Sorry I did not reply. I saw it but did not have time to review and test it yet. I'll need a few days more.

Thanks, Juan.

Hey @merlos sg, no rush.

By the way, I have another branch where I migrated CocoaPods to SPM to make the project cleaner. It seems to be working fine locally. If you have time, would you mind testing it out as well?

I didn't include it in this PR as the PR size might be a bit overwhelming, but if you don't worry too much about it, I can push them in this PR as well. Feel free to let me know.

https://github.com/weitieda/iOS-Open-GPX-Tracker/tree/swift_package_migration

@merlos merlos self-assigned this Nov 8, 2025
@merlos
Copy link
Owner

merlos commented Nov 13, 2025

Hey,
I was testing this a few days back.

Whereas I find the feature very useful.There are a couple of things that I noticed:

  1. The units are linked to the system units (imperial or metric) and does not change when the option is changed in the settings screen within the app. I took a look at mkscalebar, and I couldn't figure out if it allows changing the units.

  2. In addition to seeing the scale when the zoom changes, I find it useful to have a settings option to always display it.

For the first one, I started playing with Claude to see if it could generate a custom scale bar but still haven't finished...

My time is limited lately... let me know if would you like to work on 1 and 2?

Thanks again!!

@merlos merlos mentioned this pull request Nov 22, 2025
@merlos merlos merged commit 93e20d4 into merlos:master Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants