-
Notifications
You must be signed in to change notification settings - Fork 102
Add support for compacting database indexes #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughAdds index compaction support: new Index::compact() async method that posts to /indexes/{uid}/compact and returns TaskInfo; new TaskType variant and IndexCompaction details struct; code example and tests included. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant SDK
participant MeiliServer
User->>SDK: index.compact().await
SDK->>MeiliServer: POST /indexes/{uid}/compact
MeiliServer-->>SDK: 202 Accepted + TaskInfo
SDK-->>User: Ok(TaskInfo)
Note right of SDK: TaskInfo can be polled/tracked separately
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (4 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #728 +/- ##
==========================================
+ Coverage 86.18% 86.22% +0.03%
==========================================
Files 20 20
Lines 6263 6285 +22
==========================================
+ Hits 5398 5419 +21
- Misses 865 866 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request
Related issue
Fixes #727
What does this PR do?
.code-samples.meilisearch.yamlso fixed that as well.PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!
Summary by CodeRabbit
New Features
Documentation