feat(treewide): lazy load resources from internet on first use #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikstur
force-pushed
the
lazy-loading
branch
from
f1a3963 to
2c09cfa
Compare
nikstur
force-pushed
the
lazy-loading
branch
2 times, most recently
from
ffbb4df to
e84efe4
Compare
Now, nothing is dynamically downloaded from the internet at install time. Instead, on first use, a cache direcory is created (`~/.cache/mdn-http-observatory`) and these files downloaded: - Mozilla CA Bundle - HSTS preload list - TLD list When one of these files is not present, it is downloaded on the next invocation. When it is present on the filesystem it is used right away. "Refreshing" these resources can then simply be done by removing the cache directory and restarting the application. It can also be done by calling `npm run refreshCache` or via `npm run maintenance`. This enables packaging mdn-http-observatory for Linux distros. Additionaly, it makes the package a little easier to understand because there is no loading of resources at various points at install time.
nikstur
force-pushed
the
lazy-loading
branch
from
e84efe4 to
8e51718
Compare
Author
|
Successfully packaged this for Nixpkgs with this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now, nothing is dynamically downloaded from the internet at install
time. Instead, on first use, a cache direcory is created
(
~/.cache/mdn-http-observatory) and these files downloaded:When one of these files is not present, it is downloaded on the next
invocation. When it is present on the filesystem it is used right away.
"Refreshing" these resources can then simply be done by removing the
cache directory and restarting the application. It can also be done by
calling
npm run refreshCacheor vianpm run maintenance.This enables packaging mdn-http-observatory for Linux distros.
Addittionaly, it makes the package a little easier to understand because
there is no loading of resources at various points at install time.
Motivation
Make distro packaging possible.
Related issues and pull requests
Closes #348