Skip to content

Conversation

@pedaars
Copy link
Contributor

@pedaars pedaars commented Oct 23, 2025

Description

update the google analytics id image in the utm_tags.rst file for V7.0

Linked issue

Closes #484

Screenshots or screen recordings

Screenshot 2025-10-23 at 18 41 21

@pedaars pedaars requested a review from a team as a code owner October 23, 2025 17:55
@pedaars pedaars requested review from adiati98 and favour-chibueze and removed request for a team October 23, 2025 17:55
Copy link
Contributor

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pedaars,

Thanks so much for the PR! ✨

Just one small thing here. Can you please change the image name from dash to underscore following the removed image? So it should be add_google_analytics_id.png.

@adiati98 adiati98 added documentation Improvements or additions to documentation enhancement New feature or request pending-feedback labels Oct 26, 2025
@pedaars
Copy link
Contributor Author

pedaars commented Oct 27, 2025

Hi @adiati98,

I can but just to highlight that there is no consistency with image names some are snake_case and some are kebab-case so should probably set some standards for naming across the project

@pedaars
Copy link
Contributor Author

pedaars commented Oct 27, 2025

@adiati98 updated

@pedaars pedaars requested a review from adiati98 October 27, 2025 20:39
@adiati98
Copy link
Contributor

I can but just to highlight that there is no consistency with image names some are snake_case and some are kebab-case so should probably set some standards for naming across the project

@pedaars thank you for pointing that out. ✨
Yes, we're aware of the inconsistency. Therefore, we're updating the file names as we update the images.

Copy link
Contributor

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @pedaars! LGTM! 🚀

@holopin-bot
Copy link

holopin-bot bot commented Oct 28, 2025

Congratulations @pedaars, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmhadfsv2006cl404zjcaom35

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@adiati98 adiati98 merged commit 8a01be5 into mautic:7.0 Oct 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request hacktoberfest-2025 hacktoberfest-accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants