-
Notifications
You must be signed in to change notification settings - Fork 63
update the google analytics id image in the utm_tags.rst file for V7.0 #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update the google analytics id image in the utm_tags.rst file for V7.0 #540
Conversation
adiati98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @pedaars,
Thanks so much for the PR! ✨
Just one small thing here. Can you please change the image name from dash to underscore following the removed image? So it should be add_google_analytics_id.png.
|
Hi @adiati98, I can but just to highlight that there is no consistency with image names some are snake_case and some are kebab-case so should probably set some standards for naming across the project |
|
@adiati98 updated |
@pedaars thank you for pointing that out. ✨ |
adiati98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @pedaars! LGTM! 🚀
|
Congratulations @pedaars, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmhadfsv2006cl404zjcaom35 This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Description
update the google analytics id image in the utm_tags.rst file for V7.0
Linked issue
Closes #484
Screenshots or screen recordings