Skip to content

Optional enable pin #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Optional enable pin #57

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
663c3ec
made enable pin optional
Bascy Mar 5, 2025
498bfcc
Restore unneeded format changes
Bascy Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/dsmr/reader.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@

namespace dsmr {

#define NO_PIN 0xff

/**
* Controls the request pin on the P1 port to enable (periodic)
* transmission of messages and reads those messages.
Expand Down Expand Up @@ -69,10 +71,12 @@ class P1Reader {
* output, the Stream is assumed to be already set up (e.g. baud
* rate configured).
*/
P1Reader(Stream *stream, uint8_t req_pin)
P1Reader(Stream *stream, uint8_t req_pin = NO_PIN)
: stream(stream), req_pin(req_pin), once(false), state(State::DISABLED_STATE) {
pinMode(req_pin, OUTPUT);
digitalWrite(req_pin, LOW);
if (req_pin != NO_PIN) {
pinMode(req_pin, OUTPUT);
digitalWrite(req_pin, LOW);
}
}

/**
Expand All @@ -84,7 +88,8 @@ class P1Reader {
* periodically.
*/
void enable(bool once) {
digitalWrite(this->req_pin, HIGH);
if (req_pin != NO_PIN)
digitalWrite(this->req_pin, HIGH);
this->state = State::WAITING_STATE;
this->once = once;
}
Expand All @@ -95,7 +100,8 @@ class P1Reader {
* clear() is called.
*/
void disable() {
digitalWrite(this->req_pin, LOW);
if (req_pin != NO_PIN)
digitalWrite(this->req_pin, LOW);
this->state = State::DISABLED_STATE;
if (!this->_available)
this->buffer = "";
Expand Down Expand Up @@ -138,7 +144,7 @@ class P1Reader {
this->_available = true;

if (once)
this->disable();
this->disable();

return true;
}
Expand Down