Skip to content

Conversation

@matdev83
Copy link
Owner

@matdev83 matdev83 commented Nov 7, 2025

Summary

  • extract configuration helper routines into src/core/config/_app_config_utils.py and import them from app_config.py
  • move configuration data model classes into src/core/config/_app_config_models.py
  • slim src/core/config/app_config.py by re-exporting the new helpers and models, leaving the AppConfig definition focused on configuration assembly

Testing

  • python -m pytest -n0 (fails: ModuleNotFoundError: No module named 'pytest_mock')

Codex Task

@coderabbitai
Copy link

coderabbitai bot commented Nov 7, 2025

Warning

Rate limit exceeded

@matdev83 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 49 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between c03159e and 20f9c0e.

📒 Files selected for processing (2)
  • src/core/config/_app_config_models.py (1 hunks)
  • src/core/config/_app_config_utils.py (1 hunks)
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch codex/refactor-large-monolithic-files-to-smaller-modules-izvmid

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +126 to +128
def model_is_functional(self, model_id: str) -> bool:
"""Check if a model is available in any functional backend."""
return self.backends.model_is_functional(model_id)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Reintroduce BackendSettings.model_is_functional

AppConfig.model_is_functional now delegates to self.backends.model_is_functional, but the refactor moved BackendSettings to _app_config_models.py without carrying over its model_is_functional method. Because BackendSettings.__getattr__ returns a BackendConfig for unknown attributes, this call now produces a BackendConfig object and raises TypeError: 'BackendConfig' object is not callable. Any code that checks whether a backend/model is functional will crash. Restore the helper on BackendSettings so the method call continues to work.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants