Skip to content

Convert comboboxes to inputs for SLDS2 #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 29, 2025
Merged

Convert comboboxes to inputs for SLDS2 #494

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ecf365b
Revert "(Picklist): rename `buttonRef` with `inputRef`"
msmx-mnakagawa Jul 24, 2025
6314b0d
(Picklist, Lookup): convert tags of elements with `role="combobox"` t…
msmx-mnakagawa Jul 24, 2025
6ab7b63
(Picklist): execute `extractTextContent()` inside `extractTextContent()`
msmx-mnakagawa Jul 29, 2025
4adb664
(Picklist, Lookup): use inputs with `type="text"` for better a11y
msmx-mnakagawa Jul 29, 2025
b226640
tweak a style of `Picklist` input
msmx-mnakagawa Jul 29, 2025
2ecc7a4
Merge branch 'master' into support-slds-2-convert-comboboxes-to-buttons
msmx-mnakagawa Jul 29, 2025
42543c5
(Picklist): remove a style disabling a focus outline
msmx-mnakagawa Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/scripts/Picklist.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { FormElement, FormElementProps } from './FormElement';
import { Icon } from './Icon';
import { AutoAlign, RectangleAlignment } from './AutoAlign';
import { DropdownMenuProps } from './DropdownMenu';
import { isElInChildren } from './util';
import { registerStyle, isElInChildren } from './util';
import { ComponentSettingsContext } from './ComponentSettings';
import { useControlledValue, useEventCallback, useMergeRefs } from './hooks';
import { createFC } from './common';
Expand Down Expand Up @@ -185,6 +185,18 @@ const PicklistContext = createContext<{
optionIdPrefix: '',
});

/**
*
*/
function useInitComponentStyle() {
useEffect(() => {
registerStyle('picklist', [
['.react-picklist-input:focus-visible', '{ outline: none; }'],
Copy link
Collaborator

@stomita stomita Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are willing to cancel the focus ring of the control, it is not working right now.
I think it is not required to remove the ring for the focused picklist.

Copy link
Collaborator Author

@msmx-mnakagawa msmx-mnakagawa Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stomita
I got it.
I fixed it in 42543c5.

['.react-picklist-input:not(:disabled)', '{ cursor: pointer; }'],
]);
}, []);
}

/**
*
*/
Expand Down Expand Up @@ -262,6 +274,8 @@ export const Picklist: (<MultiSelect extends boolean | undefined>(
...rprops
} = props;

useInitComponentStyle();

const fallbackId = useId();
const id = id_ ?? fallbackId;
const listboxId = `${id}-listbox`;
Expand Down Expand Up @@ -557,6 +571,7 @@ export const Picklist: (<MultiSelect extends boolean | undefined>(
}
);
const inputClassNames = classnames(
'react-picklist-input',
'slds-input_faux',
'slds-combobox__input',
{
Expand Down