Skip to content

z80dma.cpp: Relaxed fatal error which were used for unknown commands catching. #14627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2025
+4 −3
Merged

z80dma.cpp: Relaxed fatal error which were used for unknown commands catching. #14627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/devices/machine/z80dma.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,10 +850,11 @@ void z80dma_device::write(u8 data)
logerror("Z80DMA Unknown WR6 command %02x\n", data);
}
}
else if (data == 0x8e) //newtype on Sharp X1, unknown purpose
logerror("Z80DMA Unknown base register %02x\n", data);
else
fatalerror("Z80DMA '%s' Unknown base register %02x\n", tag(), data);
{
// 0x8e: newtype on Sharp X1, unknown purpose
logerror("Z80DMA '%s' Unknown base register %02x\n", tag(), data);
Comment on lines +855 to +856
Copy link
Member

@cuavas cuavas Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logerror is a device_t member function and always includes the tag. You don’t need to duplicate it in the message.

Copy link
Contributor Author

@holub holub Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will change in one of the following commits

Copy link
Member

@angelosa angelosa Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the other SWs that triggers this btw?

Copy link
Member

@cuavas cuavas Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve already got it staged locally. I realise it was just an oversight converting from throwing emu_fatalerror to logerror.

Copy link
Contributor Author

@holub holub Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the other SWs that triggers this btw?

The Next's DMA extends this one. Recently we found an example where multiple software write 0xCA and this command is not documented anywhere (not only this one, but few other are crashing same way):
https://github.com/mikedailly/mod_player/blob/0c46930c3c0a2aa4679718452935853fe89c1774/mod_player/utils.asm#L627

db $ca ; unknown

DMA in Spectrum is cursed. Many soft is based on examples from Magazines which either had typo or used rare clone of z80dma chip.

}
m_cur_follow = 0;
}
else
Expand Down
Loading