-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fix some stuff #14609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix some stuff #14609
Conversation
vtarchive
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i did
|
Please give the pull requests a specific and descriptive title. Also, what are your sources for the changes? |
|
from the official VTech website |
vtarchive
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i added known undumpd
|
Can you provide a link for the release date changes? |
|
wayback machine: https://vtech.es |
|
You also changed the release years, changed the description of the English-language version to say it’s US-specific without providing a reference for why you believe there are different versions for other English-speaking regions (e.g. UK and Australia), and gave the PR a nondescript title. You need to address that. |
If there’s a version of the page showing that these versions existed (e.g. with catalogue numbers), please link to it directly. |
those exist |
No description provided.