-
Notifications
You must be signed in to change notification settings - Fork 683
Main resolve conflict #4568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Main resolve conflict #4568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* v14.3.1-alpha1 * Merge pull request #4525 from magento/patch/npm-access-update-live-search Adding Public Access to publish to NPM * v14.3.1-alpha12 * v14.3.1-beta1 * PWA-14.3.1 release notes (#4530) * PWA-14.3.1 release notes (#4531) * Update magento-compatibility.js (#4532) * v14.3.1 --------- Co-authored-by: devops-pwa-codebuild <magento-devops-github-pwa-int@adobe.com> Co-authored-by: Ilesh Tiwari <del15881@adobe.com>
#4537) * Prevent Cart Creation for Guest User and Add Functionality To Create Cart only when Guest User Adds Product to Cart * Fixing Prettier and Snapshot test cases * Removing unwanted and commented out code
* PWA-3576::Video component issue in dynamic CMS block * PWA-3576::Video component issue in dynamic CMS block
…nts and add in useApp talon to avoid infinite loop (#4543) Co-authored-by: Jose Amietta <joseamietta@gmail.com>
* Prevent Cart Creation for Guest User and Add Functionality To Create Cart only when Guest User Adds Product to Cart * Fixing Prettier and Snapshot test cases * Removing unwanted and commented out code * Handle Cart Creation and Merging for the Logged In users * Adding Logic To create a Cart when Products added to cart from wishlist Page * Fixing all the Failing Test cases related to Wishlist * Fixing Failing Test Cases for ADD TO CART Dialog box * Fixing Cart related test cases
Co-authored-by: glo82145 <glo82145@adobe.com>
Co-authored-by: glo82145 <glo82145@adobe.com>
Co-authored-by: Bharathidasan Elangovan <del22123@adobe.com>
* PWA-3610: Fixed targetables call * PWA-3610: Fixed targetables call
* Fixing the Issues with Targetables on Release blocker * Fixing Prettier Issues
* PWA-3613: RI-Wishlist pagination fix * PWA-3613:Fixed lint and prettier issues --------- Co-authored-by: Bharathidasan Elangovan <del22123@adobe.com>
* PWA-3610: Fixed targetables call * PWA-14.4.0 - Change log * PWA-14.4.0 - Change log * PWA-14.4.0 - Change log * PWA-14.4.0 - Change log
* PWA-3610: Fixed targetables call * PWA-14.4.0 - Change log
* PWA-3610: Fixed targetables call * PWA-14.4.0 - Change log * PWA-14.4.0 - Change log * PWA-14.4.0 - Change log
Collaborator
LogERROR ON TASK: lighthouseTests |
Collaborator
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TODO: Describe your changes in detail here.
Related Issue
Closes #ISSUE_NUMBER.
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist