MAGETWO-90863: Error handling responses from MBI

Author: fascinosum

app/code/Magento/Analytics/Test/Unit/Model/Connector/Http/Client/CurlTest.php

@@ -12,6 +12,7 @@
 
 /**
  * A unit test for testing of the CURL HTTP client.
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class CurlTest extends \PHPUnit\Framework\TestCase
 {

app/code/Magento/Braintree/Test/Unit/Model/Paypal/Helper/QuoteUpdaterTest.php

@@ -51,6 +51,9 @@ class QuoteUpdaterTest extends \PHPUnit\Framework\TestCase
      */
     private $quoteUpdater;
 
+    /**
+     * @return void
+     */
     protected function setUp()
     {
         $this->configMock = $this->getMockBuilder(Config::class)
@@ -99,6 +102,10 @@ protected function setUp()
         );
     }
 
+    /**
+     * @return void
+     * @throws \Magento\Framework\Exception\LocalizedException
+     */
     public function testExecute()
     {
         $details = $this->getDetails();
@@ -121,6 +128,9 @@ public function testExecute()
         $this->quoteUpdater->execute(self::TEST_NONCE, $details, $quoteMock);
     }
 
+    /**
+     * @return void
+     */
     private function disabledQuoteAddressValidationStep()
     {
         $this->billingAddressMock->expects(self::once())

app/code/Magento/Msrp/Test/Unit/Ui/DataProvider/Product/Listing/Collector/MsrpPriceTest.php

@@ -50,6 +50,9 @@ class MsrpPriceTest extends \PHPUnit\Framework\TestCase
      */
     private $priceInfoExtensionFactory;
 
+    /**
+     * @return void
+     */
     protected function setUp()
     {
         $this->priceCurrencyMock = $this->getMockBuilder(\Magento\Framework\Pricing\PriceCurrencyInterface::class)
@@ -86,6 +89,9 @@ protected function setUp()
         );
     }
 
+    /**
+     * @return void
+     */
     public function testCollect()
     {
         $product = $this->getMockBuilder(Product::class)

app/code/Magento/Sales/Test/Unit/Controller/Adminhtml/Order/Create/ReorderTest.php

@@ -108,6 +108,9 @@ class ReorderTest extends \PHPUnit\Framework\TestCase
      */
     private $orderId;
 
+    /**
+     * @return void
+     */
     protected function setUp()
     {
         $this->orderId = 111;
@@ -161,6 +164,9 @@ protected function setUp()
         );
     }
 
+    /**
+     * @return void
+     */
     public function testExecuteForward()
     {
         $this->clearStorage();
@@ -171,6 +177,9 @@ public function testExecuteForward()
         $this->assertInstanceOf(Forward::class, $this->reorder->execute());
     }
 
+    /**
+     * @return void
+     */
     public function testExecuteRedirectOrderGrid()
     {
         $this->clearStorage();
@@ -183,6 +192,9 @@ public function testExecuteRedirectOrderGrid()
         $this->assertInstanceOf(Redirect::class, $this->reorder->execute());
     }
 
+    /**
+     * @return void
+     */
     public function testExecuteRedirectBack()
     {
         $this->clearStorage();
@@ -197,6 +209,9 @@ public function testExecuteRedirectBack()
         $this->assertInstanceOf(Redirect::class, $this->reorder->execute());
     }
 
+    /**
+     * @return void
+     */
     public function testExecuteRedirectNewOrder()
     {
         $this->clearStorage();
@@ -211,6 +226,9 @@ public function testExecuteRedirectNewOrder()
         $this->assertInstanceOf(Redirect::class, $this->reorder->execute());
     }
 
+    /**
+     * @return void
+     */
     private function clearStorage()
     {
         $this->objectManagerMock->expects($this->at(0))
@@ -220,6 +238,9 @@ private function clearStorage()
         $this->quoteSessionMock->expects($this->once())->method('clearStorage')->will($this->returnSelf());
     }
 
+    /**
+     * @return void
+     */
     private function getOrder()
     {
         $this->requestMock->expects($this->once())
@@ -237,20 +258,26 @@ private function getOrder()
      */
     private function canReorder($result)
     {
-        $entity_id = 1;
-        $this->orderMock->expects($this->once())->method('getEntityId')->willReturn($entity_id);
+        $entityId = 1;
+        $this->orderMock->expects($this->once())->method('getEntityId')->willReturn($entityId);
         $this->reorderHelperMock->expects($this->once())
             ->method('canReorder')
-            ->with($entity_id)
+            ->with($entityId)
             ->willReturn($result);
     }
 
+    /**
+     * @return void
+     */
     private function prepareForward()
     {
         $this->resultForwardFactoryMock->expects($this->once())->method('create')->willReturn($this->resultForwardMock);
         $this->resultForwardMock->expects($this->once())->method('forward')->with('noroute')->willReturnSelf();
     }
 
+    /**
+     * @return void
+     */
     private function createRedirect()
     {
         $this->resultRedirectFactoryMock->expects($this->once())
@@ -286,6 +313,9 @@ private function getUnavailableProducts(array $unavailableProducts)
             ->willReturn($unavailableProducts);
     }
 
+    /**
+     * @return void
+     */
     private function initFromOrder()
     {
         $this->orderMock->expects($this->once())->method('setReordered')->with(true)->willReturnSelf();

app/code/Magento/Sales/Test/Unit/Model/Order/ConfigTest.php

@@ -38,6 +38,9 @@ class ConfigTest extends \PHPUnit\Framework\TestCase
      */
     protected $storeManagerMock;
 
+    /**
+     * @return void
+     */
     protected function setUp()
     {
         $objectManager = new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this);
@@ -64,6 +67,9 @@ protected function setUp()
             );
     }
 
+    /**
+     * @return void
+     */
     public function testGetInvisibleOnFrontStatuses()
     {
         $statuses = [
@@ -110,6 +116,9 @@ public function testGetInvisibleOnFrontStatuses()
         $this->assertSame($expectedResult, $result);
     }
 
+    /**
+     * @return void
+     */
     public function testGetStateLabelByStateAndStatus()
     {
         $statuses = [

app/code/Magento/Tax/Test/Unit/Ui/DataProvider/Product/Listing/Collector/TaxTest.php

@@ -54,6 +54,9 @@ class TaxTest extends \PHPUnit\Framework\TestCase
      */
     private $formattedPriceInfoBuilder;
 
+    /**
+     * @return void
+     */
     protected function setUp()
     {
         $this->priceCurrencyMock = $this->getMockBuilder(PriceCurrencyInterface::class)
@@ -88,6 +91,9 @@ protected function setUp()
         );
     }
 
+    /**
+     * @return void
+     */
     public function testCollect()
     {
         $amountValue = 10;

app/code/Magento/Weee/Test/Unit/Ui/DataProvider/Product/Listing/Collector/WeeeTest.php

@@ -41,6 +41,9 @@ class WeeeTest extends \PHPUnit\Framework\TestCase
     /** @var FormattedPriceInfoBuilder|\PHPUnit_Framework_MockObject_MockObject */
     private $formattedPriceInfoBuilder;
 
+    /**
+     * @return void
+     */
     protected function setUp()
     {
         $this->weeeHelperMock = $this->getMockBuilder(\Magento\Weee\Helper\Data::class)
@@ -76,6 +79,9 @@ protected function setUp()
         );
     }
 
+    /**
+     * @return void
+     */
     public function testCollect()
     {
         $productMock = $this->getMockBuilder(Product::class)