MAGETWO-90863: Error handling responses from MBI

Author: fascinosum

app/code/Magento/Analytics/Test/Unit/Model/Connector/Http/Client/CurlTest.php

@@ -104,7 +104,9 @@ public function getTestData()
     }
 
     /**
+     * @param array $data
      * @return void
+     * @throws \Zend_Http_Exception
      * @dataProvider getTestData
      */
     public function testRequestSuccess(array $data)
@@ -145,7 +147,9 @@ public function testRequestSuccess(array $data)
     }
 
     /**
+     * @param array $data
      * @return void
+     * @throws \Zend_Http_Exception
      * @dataProvider getTestData
      */
     public function testRequestError(array $data)

app/code/Magento/Analytics/Test/Unit/Model/Connector/Http/JsonConverterTest.php

@@ -25,6 +25,9 @@ class JsonConverterTest extends \PHPUnit\Framework\TestCase
      */
     private $converter;
 
+    /**
+     * @return void
+     */
     protected function setUp()
     {
         $this->objectManagerHelper = new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this);
@@ -37,6 +40,9 @@ protected function setUp()
         );
     }
 
+    /**
+     * @return void
+     */
     public function testConverterContainsHeader()
     {
         $this->assertEquals(
@@ -69,6 +75,9 @@ public function convertBodyDataProvider()
         ];
     }
 
+    /**
+     *  return void
+     */
     public function testConvertData()
     {
         $this->serializerMock->expects($this->once())

app/code/Magento/Analytics/Test/Unit/Model/Connector/SignUpCommandTest.php

@@ -57,6 +57,9 @@ class SignUpCommandTest extends \PHPUnit\Framework\TestCase
      */
     private $responseResolverMock;
 
+    /**
+     * @return void
+     */
     protected function setUp()
     {
         $this->analyticsTokenMock =  $this->getMockBuilder(AnalyticsToken::class)
@@ -91,6 +94,10 @@ protected function setUp()
         );
     }
 
+    /**
+     * @throws \Zend_Http_Exception
+     * @return void
+     */
     public function testExecuteSuccess()
     {
         $this->integrationManagerMock->expects($this->once())
@@ -124,6 +131,9 @@ public function testExecuteSuccess()
         $this->assertTrue($this->signUpCommand->execute());
     }
 
+    /**
+     * @return void
+     */
     public function testExecuteFailureCannotGenerateToken()
     {
         $this->integrationManagerMock->expects($this->once())
@@ -134,6 +144,10 @@ public function testExecuteFailureCannotGenerateToken()
         $this->assertFalse($this->signUpCommand->execute());
     }
 
+    /**
+     * @throws \Zend_Http_Exception
+     * @return void
+     */
     public function testExecuteFailureResponseIsEmpty()
     {
         $this->integrationManagerMock->expects($this->once())

app/code/Magento/Braintree/Test/Unit/Model/Paypal/Helper/QuoteUpdaterTest.php

@@ -300,7 +300,7 @@ private function getQuoteMock()
         $cartExtensionMock = $this->getMockBuilder(CartExtensionInterface::class)
             ->setMethods(['setShippingAssignments'])
             ->disableOriginalConstructor()
-            ->getMock();
+            ->getMockForAbstractClass();
 
         $quoteMock->expects(self::any())
             ->method('getExtensionAttributes')

app/code/Magento/Msrp/Test/Unit/Ui/DataProvider/Product/Listing/Collector/MsrpPriceTest.php

@@ -101,7 +101,7 @@ public function testCollect()
             \Magento\Catalog\Api\Data\ProductRender\PriceInfoExtensionInterface::class
         )
             ->setMethods(['setMsrp'])
-            ->getMock();
+            ->getMockForAbstractClass();
 
         $priceInfo = $this->getMockBuilder(MsrpPriceInfoInterface::class)
             ->setMethods(['getPrice', 'getExtensionAttributes'])

app/code/Magento/Sales/Test/Unit/Controller/Adminhtml/Order/Create/ReorderTest.php

@@ -118,7 +118,9 @@ protected function setUp()
             ->getMock();
         $this->requestMock = $this->getMockBuilder(RequestInterface::class)->getMockForAbstractClass();
         $this->objectManagerMock = $this->getMockBuilder(ObjectManagerInterface::class)->getMockForAbstractClass();
-        $this->resultForwardFactoryMock = $this->getMockBuilder(ForwardFactory::class)->getMock();
+        $this->resultForwardFactoryMock = $this->getMockBuilder(ForwardFactory::class)
+            ->disableOriginalConstructor()
+            ->getMock();
         $this->resultRedirectFactoryMock = $this->getMockBuilder(RedirectFactory::class)
             ->disableOriginalConstructor()
             ->getMock();

app/code/Magento/Sales/Test/Unit/Model/Order/ConfigTest.php

@@ -47,6 +47,7 @@ protected function setUp()
             'storeManager' => $this->storeManagerMock,
         ]);
         $this->statusFactoryMock = $this->getMockBuilder(\Magento\Sales\Model\Order\StatusFactory::class)
+            ->disableOriginalConstructor()
             ->setMethods(['load', 'create'])
             ->getMock();
         $this->orderStatusCollectionFactoryMock = $this->createPartialMock(

app/code/Magento/Tax/Test/Unit/Ui/DataProvider/Product/Listing/Collector/TaxTest.php

@@ -68,10 +68,12 @@ protected function setUp()
             ->getMockForAbstractClass();
 
         $this->priceInfoFactory = $this->getMockBuilder(PriceInfoInterfaceFactory::class)
+            ->disableOriginalConstructor()
             ->setMethods(['create'])
             ->getMock();
 
         $this->priceInfoExtensionFactory = $this->getMockBuilder(PriceInfoExtensionInterfaceFactory::class)
+            ->disableOriginalConstructor()
             ->setMethods(['create'])
             ->getMock();
         $this->formattedPriceInfoBuilder = $this->getMockBuilder(FormattedPriceInfoBuilder::class)

app/code/Magento/Weee/Test/Unit/Ui/DataProvider/Product/Listing/Collector/WeeeTest.php

@@ -50,14 +50,16 @@ protected function setUp()
             ->getMockForAbstractClass();
 
         $this->weeeAdjustmentAttributeFactory = $this->getMockBuilder(WeeeAdjustmentAttributeInterfaceFactory::class)
+            ->disableOriginalConstructor()
             ->setMethods(['create'])
             ->getMock();
 
         $this->extensionAttributes = $this->getMockBuilder(PriceInfoExtensionInterface::class)
             ->setMethods(['setWeeeAttributes', 'setWeeeAdjustment'])
-            ->getMock();
+            ->getMockForAbstractClass();
 
         $this->priceInfoExtensionFactory = $this->getMockBuilder(PriceInfoExtensionInterfaceFactory::class)
+            ->disableOriginalConstructor()
             ->setMethods(['create'])
             ->getMock();