ACP2E-1243: the catalog_index_refresh_price cron fails with an error that is only reported when run between 0000 and 0059 UTC

Author: dhorytskyi

app/code/Magento/Catalog/Cron/RefreshSpecialPrices.php

@@ -6,7 +6,6 @@
 namespace Magento\Catalog\Cron;
 
 use Magento\Catalog\Api\Data\CategoryInterface;
-use Magento\Framework\App\ObjectManager;
 use Magento\Framework\App\ResourceConnection;
 use Magento\Framework\EntityManager\MetadataPool;
 
@@ -59,21 +58,24 @@ class RefreshSpecialPrices
      * @param \Magento\Framework\Stdlib\DateTime\TimezoneInterface $localeDate
      * @param \Magento\Eav\Model\Config $eavConfig
      * @param \Magento\Catalog\Model\Indexer\Product\Price\Processor $processor
+     * @param MetadataPool $metadataPool
      */
     public function __construct(
         \Magento\Store\Model\StoreManagerInterface $storeManager,
         ResourceConnection $resource,
         \Magento\Framework\Stdlib\DateTime $dateTime,
         \Magento\Framework\Stdlib\DateTime\TimezoneInterface $localeDate,
         \Magento\Eav\Model\Config $eavConfig,
-        \Magento\Catalog\Model\Indexer\Product\Price\Processor $processor
+        \Magento\Catalog\Model\Indexer\Product\Price\Processor $processor,
+        MetadataPool $metadataPool
     ) {
         $this->_storeManager = $storeManager;
         $this->_resource = $resource;
         $this->_dateTime = $dateTime;
         $this->_localeDate = $localeDate;
         $this->_eavConfig = $eavConfig;
         $this->_processor = $processor;
+        $this->metadataPool = $metadataPool;
     }
 
     /**
@@ -139,8 +141,8 @@ protected function _refreshSpecialPriceByStore($storeId, $attrCode, $attrConditi
         $attribute = $this->_eavConfig->getAttribute(\Magento\Catalog\Model\Product::ENTITY, $attrCode);
         $attributeId = $attribute->getAttributeId();
 
-        $linkField = $this->getMetadataPool()->getMetadata(CategoryInterface::class)->getLinkField();
-        $identifierField = $this->getMetadataPool()->getMetadata(CategoryInterface::class)->getIdentifierField();
+        $linkField = $this->metadataPool->getMetadata(CategoryInterface::class)->getLinkField();
+        $identifierField = $this->metadataPool->getMetadata(CategoryInterface::class)->getIdentifierField();
 
         $connection = $this->_getConnection();
 
@@ -170,18 +172,4 @@ protected function _refreshSpecialPriceByStore($storeId, $attrCode, $attrConditi
             $this->_processor->getIndexer()->reindexList($selectData);
         }
     }
-
-    /**
-     * Get MetadataPool instance
-     * @return MetadataPool
-     *
-     * @deprecated 101.0.0
-     */
-    private function getMetadataPool()
-    {
-        if (null === $this->metadataPool) {
-            $this->metadataPool = ObjectManager::getInstance()->get(MetadataPool::class);
-        }
-        return $this->metadataPool;
-    }
 }