ACP2E-1243: the catalog_index_refresh_price cron fails with an error that is only reported when run between 0000 and 0059 UTC

Author: dhorytskyi

app/code/Magento/Catalog/Cron/RefreshSpecialPrices.php

@@ -164,7 +164,7 @@ protected function _refreshSpecialPriceByStore($storeId, $attrCode, $attrConditi
             $attrConditionValue
         );
 
-        $selectData = $connection->fetchCol($select, $identifierField);
+        $selectData = $connection->fetchCol($select);
 
         if (!empty($selectData)) {
             $this->_processor->getIndexer()->reindexList($selectData);

app/code/Magento/Catalog/Test/Unit/Cron/RefreshSpecialPricesTest.php

@@ -18,7 +18,6 @@
 use Magento\Framework\EntityManager\MetadataPool;
 use Magento\Framework\Stdlib\DateTime;
 use Magento\Framework\Stdlib\DateTime\TimezoneInterface;
-use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Magento\Indexer\Model\Indexer;
 use Magento\Store\Model\Store;
 use Magento\Store\Model\StoreManagerInterface;
@@ -30,11 +29,6 @@
  */
 class RefreshSpecialPricesTest extends TestCase
 {
-    /**
-     * @var ObjectManager
-     */
-    protected $_objectManager;
-
     /**
      * @var RefreshSpecialPrices
      */
@@ -82,8 +76,6 @@ class RefreshSpecialPricesTest extends TestCase
 
     protected function setUp(): void
     {
-        $this->_objectManager = new ObjectManager($this);
-
         $this->_storeManagerMock = $this->getMockForAbstractClass(StoreManagerInterface::class);
         $this->_resourceMock = $this->createMock(ResourceConnection::class);
         $this->_dateTimeMock = $this->createMock(DateTime::class);
@@ -93,16 +85,13 @@ protected function setUp(): void
 
         $this->metadataMock = $this->createMock(EntityMetadata::class);
 
-        $this->_model = $this->_objectManager->getObject(
-            RefreshSpecialPrices::class,
-            [
-                'storeManager' => $this->_storeManagerMock,
-                'resource' => $this->_resourceMock,
-                'dateTime' => $this->_dateTimeMock,
-                'localeDate' => $this->_localeDateMock,
-                'eavConfig' => $this->_eavConfigMock,
-                'processor' => $this->_priceProcessorMock
-            ]
+        $this->_model = new RefreshSpecialPrices(
+            $this->_storeManagerMock,
+            $this->_resourceMock,
+            $this->_dateTimeMock,
+            $this->_localeDateMock,
+            $this->_eavConfigMock,
+            $this->_priceProcessorMock
         );
 
         $this->metadataPool = $this->createMock(MetadataPool::class);
@@ -132,13 +121,10 @@ public function testRefreshSpecialPrices()
 
         $connectionMock = $this->getMockForAbstractClass(AdapterInterface::class);
         $connectionMock->expects($this->any())->method('select')->willReturn($selectMock);
-        $connectionMock->expects(
-            $this->any()
-        )->method(
-            'fetchCol'
-        )->willReturn(
-            $idsToProcess
-        );
+        $connectionMock->expects($this->exactly(2))
+            ->method('fetchCol')
+            ->with($selectMock, [])
+            ->willReturn($idsToProcess);
 
         $this->_resourceMock->expects(
             $this->once()