DM-44440: Match conda-forge's MACOSX_DEPLOYMENT_TARGET #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-44440
branch
from
5d2d5df to
24be355
Compare
timj
reviewed
Feb 27, 2025
| if uname.sysname == "Darwin" and uname.machine == "arm64": | ||
| return "11.0" | ||
| return "10.9" | ||
| return "10.13" |
Member
There was a problem hiding this comment.
It seems that we probably should also use the env var if we know we are in a conda environment (since it is set by conda).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
=======================================
Coverage 85.36% 85.36%
=======================================
Files 5 5
Lines 41 41
Branches 3 3
=======================================
Hits 35 35
Misses 3 3
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.