Bring single page title in line with other DW practice #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generally, in Dokuwiki either the first page heading or (in the absence of that) the page name without the namespace is used as the page title.
lpaulsen93
requested changes
Nov 27, 2017
Owner
lpaulsen93
left a comment
lpaulsen93
left a comment
There was a problem hiding this comment.
I think the default should be the page ID and the decision to use the first heading should be based on the config. E.g. see function tpl_pagetitle() in file inc/template.php.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exporting a single page, the ODT plugin uses the page ID as the title of the generated ODT document. This is contrary to general Dokuwiki practice, which uses the first page heading, or (in the absence of that) the page name without the namespace as the page title.
This patch recitifies that by generating the title in a way more consistent with for example many navigation plugins.