Skip to content

fixed prop types #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixed prop types #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30f7551
fixed prop types
Dec 2, 2022
e563f2e
update package and README
Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/react-nipple/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# NOTICE

The [original repo](https://github.com/loopmode/react-nipple) is no longer maintained so I created this fork to fix the annoying warning about prop types. Here is my open [pull request](https://github.com/loopmode/react-nipple/pull/54).

# react-nipple

A react wrapper for the [nipplejs](https://www.npmjs.com/package/nipplejs) on-screen-joystick.
Expand Down
8 changes: 4 additions & 4 deletions packages/react-nipple/lib/ReactNipple.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,9 +255,9 @@ var ReactNipple = (_class = function (_Component) {
className: _propTypes2.default.string,
options: _propTypes2.default.shape({
color: _propTypes2.default.string,
size: _propTypes2.default.integer,
threshold: _propTypes2.default.float, // before triggering a directional event
fadeTime: _propTypes2.default.integer, // transition time
size: _propTypes2.default.number,
threshold: _propTypes2.default.number, // before triggering a directional event
fadeTime: _propTypes2.default.number, // transition time
multitouch: _propTypes2.default.bool,
maxNumberOfNipples: _propTypes2.default.number, // when multitouch, what is too many?
dataOnly: _propTypes2.default.bool, // no dom element whatsoever
Expand Down Expand Up @@ -288,4 +288,4 @@ var ReactNipple = (_class = function (_Component) {

return ReactNipple;
}(_react.Component), (_applyDecoratedDescriptor(_class.prototype, 'handleElement', [_autobindDecorator2.default], Object.getOwnPropertyDescriptor(_class.prototype, 'handleElement'), _class.prototype), _applyDecoratedDescriptor(_class.prototype, 'handleJoystickStart', [_autobindDecorator2.default], Object.getOwnPropertyDescriptor(_class.prototype, 'handleJoystickStart'), _class.prototype), _applyDecoratedDescriptor(_class.prototype, 'handleJoystickEnd', [_autobindDecorator2.default], Object.getOwnPropertyDescriptor(_class.prototype, 'handleJoystickEnd'), _class.prototype), _applyDecoratedDescriptor(_class.prototype, 'handleJoystickMove', [_autobindDecorator2.default], Object.getOwnPropertyDescriptor(_class.prototype, 'handleJoystickMove'), _class.prototype), _applyDecoratedDescriptor(_class.prototype, 'handleJoystickDir', [_autobindDecorator2.default], Object.getOwnPropertyDescriptor(_class.prototype, 'handleJoystickDir'), _class.prototype), _applyDecoratedDescriptor(_class.prototype, 'handleJoystickPlain', [_autobindDecorator2.default], Object.getOwnPropertyDescriptor(_class.prototype, 'handleJoystickPlain'), _class.prototype), _applyDecoratedDescriptor(_class.prototype, 'handleJoystickShown', [_autobindDecorator2.default], Object.getOwnPropertyDescriptor(_class.prototype, 'handleJoystickShown'), _class.prototype), _applyDecoratedDescriptor(_class.prototype, 'handleJoystickHidden', [_autobindDecorator2.default], Object.getOwnPropertyDescriptor(_class.prototype, 'handleJoystickHidden'), _class.prototype), _applyDecoratedDescriptor(_class.prototype, 'handleJoystickPressure', [_autobindDecorator2.default], Object.getOwnPropertyDescriptor(_class.prototype, 'handleJoystickPressure'), _class.prototype)), _class);
exports.default = ReactNipple;
exports.default = ReactNipple;
24 changes: 21 additions & 3 deletions packages/react-nipple/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-nipple",
"version": "1.0.3",
"name": "@mjforan/react-nipple",
"version": "1.0.6",
"main": "lib/index.js",
"license": "MIT",
"scripts": {
Expand All @@ -25,5 +25,23 @@
"devDependencies": {
"@loopmode/babel6-base": "^0.0.6",
"react": "^16.4.1"
}
},
"description": "A react wrapper for the [nipplejs](https://www.npmjs.com/package/nipplejs) on-screen-joystick (with fixed prop-types).",
"directories": {
"lib": "lib"
},
"repository": {
"type": "git",
"url": "git+https://github.com/mjforan/react-nipple.git"
},
"keywords": [
"react",
"nipple",
"joystick"
],
"author": "Jovica Aleksic",
"bugs": {
"url": "https://github.com/mjforan/react-nipple/issues"
},
"homepage": "https://github.com/mjforan/react-nipple/tree/master/packages/react-nipple#readme"
}
6 changes: 3 additions & 3 deletions packages/react-nipple/src/ReactNipple.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ export default class ReactNipple extends Component {
className: PropTypes.string,
options: PropTypes.shape({
color: PropTypes.string,
size: PropTypes.integer,
threshold: PropTypes.float, // before triggering a directional event
fadeTime: PropTypes.integer, // transition time
size: PropTypes.number,
threshold: PropTypes.number, // before triggering a directional event
fadeTime: PropTypes.number, // transition time
multitouch: PropTypes.bool,
maxNumberOfNipples: PropTypes.number, // when multitouch, what is too many?
dataOnly: PropTypes.bool, // no dom element whatsoever
Expand Down