fix: [Closes #164] Remove third argument to jSTouchDispatcher.handleTouchEvent call (which causes a build error on Android) #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch causes a build error on Android.
|
@brandonballinger is attempting to deploy a commit to the Jovanni's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Code Climate has analyzed commit 1690ace and detected 0 issues on this pull request. View more on Code Climate. |
3 tasks
Contributor
|
the method indeed exists (exists b4 the kotlin migration too). though this might be fine as react-native-screens also uses the 2 arg overload (which calls the 3 one with reactContext=null) |
Owner
|
Just released #211 beta. Please test it out |
Owner
|
This might cause issues on newer react-native versions. I just copied the implementation from their |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed the build issue on Android reported here for me: #164
Initially I suspected the bug was caused by a mismatch in react native versions. But I took a look at the commit history for JSTouchDispatcher in react-native, and that file hasn't been modified since 2018 and I can't find a version of handleTouchEvent which accepts the third argument used here. So I'm not entirely sure how the original code worked on Android.