Skip to content

[TOSA] Lower boolean aten.bitwise_not to logical_not #4364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[TOSA] Lower boolean aten.bitwise_not to logical_not #4364

wants to merge 1 commit into from

Conversation

@Lallapallooza
Copy link
Contributor

@Lallapallooza Lallapallooza commented Nov 3, 2025

  • Fix TorchToTosa's shared unary pattern so AtenBitwiseNotOp with i1 outputs emits tosa.logical_not instead of the tosa.bitwise_not.
  • Add a regression in test/Conversion/TorchToTosa/basic.mlir that checks the lowering path for a bool tensor.
  • Add a regression end-to-end test for bitwise_not with boolean.

@Lallapallooza
[TOSA] Lower boolean aten.bitwise_not to logical_not
cf23a4c 
- Fix TorchToTosa's shared unary pattern so AtenBitwiseNotOp with i1 outputs
emits tosa.logical_not instead of the tosa.bitwise_not.
- Add a regression in test/Conversion/TorchToTosa/basic.mlir that checks the
lowering path for a bool tensor.
- Add a regression end-to-end test for bitwise_not with boolean.

Change-Id: I1742adcd150d3a1ddb33b9dd58001d71f3e08860
@Lallapallooza
Copy link
Contributor Author

Lallapallooza commented Nov 3, 2025

@sahas3 @sjarus can you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Lallapallooza