Add new 'user_prop' argument for UnifiedTreeBuilder.getCmakeExBuildFactory factory. #647
+30
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctory factory. This argument allows factory to defined the user specified properties for the build. These properties can use used to store the common values to repeat them within the multiple CMake arguments as example.
Contributor
|
The use case is not clear to me yet. Why are the existing properties not enough? |
Contributor
Author
#629 as example. I need to assign the same compiler/linker options to few Cmake vars. It could simplify that part if we store the options into the property and use this property multiple times later instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This argument allows factory to defined the user specified properties for the build.
These properties can use used to store the common values to repeat them within the multiple CMake arguments as example.